From 296311634cb832604cc420f99f689f7b828cb36f Mon Sep 17 00:00:00 2001 From: "brian m. carlson" Date: Fri, 19 Jul 2019 13:55:14 +0000 Subject: [PATCH] ssh: redirect stdin from /dev/null When using SSH cloning with a ControlMaster socket and a password on a Unix system, we're unable to read from standard input and consequently the SSH process fails. The redirect from standard input was intended to fix an issue on Windows that is due to /dev/tty disappearing, but it doesn't appear to work and causes issues on Unix systems. Revert this change so we can explore other options. This reverts commit 59ed04855afd7e8f1bb126eb6f6a5c5297f59253. --- lfshttp/ssh.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/lfshttp/ssh.go b/lfshttp/ssh.go index 1f909807..fc8bf77c 100644 --- a/lfshttp/ssh.go +++ b/lfshttp/ssh.go @@ -4,7 +4,6 @@ import ( "bytes" "encoding/json" "fmt" - "os" "os/exec" "path/filepath" "regexp" @@ -88,7 +87,6 @@ func (c *sshAuthClient) Resolve(e Endpoint, method string) (sshAuthResponse, err // Save stdout and stderr in separate buffers var outbuf, errbuf bytes.Buffer - cmd.Stdin = os.Stdin cmd.Stdout = &outbuf cmd.Stderr = &errbuf