From ec586945c4b984c67f6a2cf92deea10557a3e419 Mon Sep 17 00:00:00 2001 From: Jukka Lehtniemi Date: Tue, 5 Apr 2016 22:34:23 +0300 Subject: [PATCH] Review fixes - Close instead of Sync since we are already done with the file - Style: Omit return value for os.Remove() --- lfs/util.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lfs/util.go b/lfs/util.go index be3b9b69..0946c97d 100644 --- a/lfs/util.go +++ b/lfs/util.go @@ -335,7 +335,7 @@ func CopyFileContents(src string, dst string) error { } defer func() { tmp.Close() - _ = os.Remove(tmp.Name()) + os.Remove(tmp.Name()) }() in, err := os.Open(src) if err != nil { @@ -346,7 +346,7 @@ func CopyFileContents(src string, dst string) error { if err != nil { return err } - err = tmp.Sync() + err = tmp.Close() if err != nil { return err }