From a7486a8d87e6b982033d9328f6474fb7d7d5371a Mon Sep 17 00:00:00 2001 From: Joel Challis Date: Tue, 24 Sep 2024 12:04:15 +0100 Subject: [PATCH] Remove `STM32_PWM_USE_ADVANCED` references (#24432) --- docs/drivers/ws2812.md | 2 +- keyboards/acheron/apollo/87h/delta/mcuconf.h | 3 --- keyboards/acheron/apollo/87htsc/mcuconf.h | 3 --- keyboards/acheron/apollo/88htsc/mcuconf.h | 3 --- keyboards/acheron/athena/alpha/mcuconf.h | 3 --- keyboards/acheron/athena/beta/mcuconf.h | 3 --- keyboards/acheron/shark/beta/mcuconf.h | 3 --- keyboards/acheron/themis/87h/mcuconf.h | 3 --- keyboards/acheron/themis/87htsc/mcuconf.h | 3 --- keyboards/acheron/themis/88htsc/mcuconf.h | 3 --- keyboards/aurora65/mcuconf.h | 3 --- keyboards/black_hellebore/mcuconf.h | 3 --- keyboards/cipulot/ec_980c/mcuconf.h | 3 --- keyboards/cipulot/ec_typek/mcuconf.h | 3 --- keyboards/meetlab/kalice/mcuconf.h | 2 -- keyboards/mode/m256wh/mcuconf.h | 3 --- keyboards/mode/m256ws/mcuconf.h | 3 --- keyboards/smithrune/iron165r2/f411/mcuconf.h | 3 --- keyboards/smithrune/magnus/m75h/mcuconf.h | 3 --- keyboards/smithrune/magnus/m75s/mcuconf.h | 3 --- keyboards/tg67/mcuconf.h | 3 --- keyboards/viendi8l/mcuconf.h | 3 --- platforms/chibios/drivers/backlight_pwm.c | 2 +- 23 files changed, 2 insertions(+), 64 deletions(-) diff --git a/docs/drivers/ws2812.md b/docs/drivers/ws2812.md index 61addf1917e..64343d3c6aa 100644 --- a/docs/drivers/ws2812.md +++ b/docs/drivers/ws2812.md @@ -236,7 +236,7 @@ The following `#define`s apply only to the `pwm` driver: |`WS2812_PWM_COMPLEMENTARY_OUTPUT`|*Not defined* |Whether the PWM output is complementary (`TIMx_CHyN`) | ::: tip -Using a complementary timer output (`TIMx_CHyN`) is possible only for advanced-control timers (1, 8 and 20 on STM32), and the `STM32_PWM_USE_ADVANCED` option in `mcuconf.h` must be set to `TRUE`. Complementary outputs of general-purpose timers are not supported due to ChibiOS limitations. +Using a complementary timer output (`TIMx_CHyN`) is possible only for advanced-control timers (1, 8 and 20 on STM32). Complementary outputs of general-purpose timers are not supported due to ChibiOS limitations. ::: ## API {#api} diff --git a/keyboards/acheron/apollo/87h/delta/mcuconf.h b/keyboards/acheron/apollo/87h/delta/mcuconf.h index 652fecfc8aa..0000e33889a 100644 --- a/keyboards/acheron/apollo/87h/delta/mcuconf.h +++ b/keyboards/acheron/apollo/87h/delta/mcuconf.h @@ -18,8 +18,5 @@ #include_next -#undef STM32_PWM_USE_ADVANCED -#define STM32_PWM_USE_ADVANCED TRUE - #undef STM32_PWM_USE_TIM1 #define STM32_PWM_USE_TIM1 TRUE diff --git a/keyboards/acheron/apollo/87htsc/mcuconf.h b/keyboards/acheron/apollo/87htsc/mcuconf.h index 652fecfc8aa..0000e33889a 100644 --- a/keyboards/acheron/apollo/87htsc/mcuconf.h +++ b/keyboards/acheron/apollo/87htsc/mcuconf.h @@ -18,8 +18,5 @@ #include_next -#undef STM32_PWM_USE_ADVANCED -#define STM32_PWM_USE_ADVANCED TRUE - #undef STM32_PWM_USE_TIM1 #define STM32_PWM_USE_TIM1 TRUE diff --git a/keyboards/acheron/apollo/88htsc/mcuconf.h b/keyboards/acheron/apollo/88htsc/mcuconf.h index 652fecfc8aa..0000e33889a 100644 --- a/keyboards/acheron/apollo/88htsc/mcuconf.h +++ b/keyboards/acheron/apollo/88htsc/mcuconf.h @@ -18,8 +18,5 @@ #include_next -#undef STM32_PWM_USE_ADVANCED -#define STM32_PWM_USE_ADVANCED TRUE - #undef STM32_PWM_USE_TIM1 #define STM32_PWM_USE_TIM1 TRUE diff --git a/keyboards/acheron/athena/alpha/mcuconf.h b/keyboards/acheron/athena/alpha/mcuconf.h index 63f1e30e641..c35579fe1c7 100644 --- a/keyboards/acheron/athena/alpha/mcuconf.h +++ b/keyboards/acheron/athena/alpha/mcuconf.h @@ -21,9 +21,6 @@ #undef STM32_I2C_USE_I2C1 #define STM32_I2C_USE_I2C1 TRUE -#undef STM32_PWM_USE_ADVANCED -#define STM32_PWM_USE_ADVANCED TRUE - #undef STM32_PWM_USE_TIM3 #define STM32_PWM_USE_TIM3 TRUE diff --git a/keyboards/acheron/athena/beta/mcuconf.h b/keyboards/acheron/athena/beta/mcuconf.h index 63f1e30e641..c35579fe1c7 100644 --- a/keyboards/acheron/athena/beta/mcuconf.h +++ b/keyboards/acheron/athena/beta/mcuconf.h @@ -21,9 +21,6 @@ #undef STM32_I2C_USE_I2C1 #define STM32_I2C_USE_I2C1 TRUE -#undef STM32_PWM_USE_ADVANCED -#define STM32_PWM_USE_ADVANCED TRUE - #undef STM32_PWM_USE_TIM3 #define STM32_PWM_USE_TIM3 TRUE diff --git a/keyboards/acheron/shark/beta/mcuconf.h b/keyboards/acheron/shark/beta/mcuconf.h index 63f1e30e641..c35579fe1c7 100644 --- a/keyboards/acheron/shark/beta/mcuconf.h +++ b/keyboards/acheron/shark/beta/mcuconf.h @@ -21,9 +21,6 @@ #undef STM32_I2C_USE_I2C1 #define STM32_I2C_USE_I2C1 TRUE -#undef STM32_PWM_USE_ADVANCED -#define STM32_PWM_USE_ADVANCED TRUE - #undef STM32_PWM_USE_TIM3 #define STM32_PWM_USE_TIM3 TRUE diff --git a/keyboards/acheron/themis/87h/mcuconf.h b/keyboards/acheron/themis/87h/mcuconf.h index 3d1d05c307c..ff2280716d6 100644 --- a/keyboards/acheron/themis/87h/mcuconf.h +++ b/keyboards/acheron/themis/87h/mcuconf.h @@ -18,8 +18,5 @@ #include_next -#undef STM32_PWM_USE_ADVANCED -#define STM32_PWM_USE_ADVANCED TRUE - #undef STM32_PWM_USE_TIM1 #define STM32_PWM_USE_TIM1 TRUE diff --git a/keyboards/acheron/themis/87htsc/mcuconf.h b/keyboards/acheron/themis/87htsc/mcuconf.h index 3d1d05c307c..ff2280716d6 100644 --- a/keyboards/acheron/themis/87htsc/mcuconf.h +++ b/keyboards/acheron/themis/87htsc/mcuconf.h @@ -18,8 +18,5 @@ #include_next -#undef STM32_PWM_USE_ADVANCED -#define STM32_PWM_USE_ADVANCED TRUE - #undef STM32_PWM_USE_TIM1 #define STM32_PWM_USE_TIM1 TRUE diff --git a/keyboards/acheron/themis/88htsc/mcuconf.h b/keyboards/acheron/themis/88htsc/mcuconf.h index 3d1d05c307c..ff2280716d6 100644 --- a/keyboards/acheron/themis/88htsc/mcuconf.h +++ b/keyboards/acheron/themis/88htsc/mcuconf.h @@ -18,8 +18,5 @@ #include_next -#undef STM32_PWM_USE_ADVANCED -#define STM32_PWM_USE_ADVANCED TRUE - #undef STM32_PWM_USE_TIM1 #define STM32_PWM_USE_TIM1 TRUE diff --git a/keyboards/aurora65/mcuconf.h b/keyboards/aurora65/mcuconf.h index 5e966ec140b..0b3baa9b4b2 100644 --- a/keyboards/aurora65/mcuconf.h +++ b/keyboards/aurora65/mcuconf.h @@ -20,6 +20,3 @@ #undef STM32_PWM_USE_TIM1 #define STM32_PWM_USE_TIM1 TRUE - -#undef STM32_PWM_USE_ADVANCED -#define STM32_PWM_USE_ADVANCED TRUE diff --git a/keyboards/black_hellebore/mcuconf.h b/keyboards/black_hellebore/mcuconf.h index ccb216946c9..51dc999135d 100644 --- a/keyboards/black_hellebore/mcuconf.h +++ b/keyboards/black_hellebore/mcuconf.h @@ -18,8 +18,5 @@ #include_next -#undef STM32_PWM_USE_ADVANCED -#define STM32_PWM_USE_ADVANCED TRUE - #undef STM32_PWM_USE_TIM1 #define STM32_PWM_USE_TIM1 TRUE diff --git a/keyboards/cipulot/ec_980c/mcuconf.h b/keyboards/cipulot/ec_980c/mcuconf.h index 5f9ecca48dd..2f22252a008 100644 --- a/keyboards/cipulot/ec_980c/mcuconf.h +++ b/keyboards/cipulot/ec_980c/mcuconf.h @@ -21,8 +21,5 @@ #undef STM32_ADC_USE_ADC1 #define STM32_ADC_USE_ADC1 TRUE -#undef STM32_PWM_USE_ADVANCED -#define STM32_PWM_USE_ADVANCED TRUE - #undef STM32_PWM_USE_TIM1 #define STM32_PWM_USE_TIM1 TRUE diff --git a/keyboards/cipulot/ec_typek/mcuconf.h b/keyboards/cipulot/ec_typek/mcuconf.h index 5f9ecca48dd..2f22252a008 100644 --- a/keyboards/cipulot/ec_typek/mcuconf.h +++ b/keyboards/cipulot/ec_typek/mcuconf.h @@ -21,8 +21,5 @@ #undef STM32_ADC_USE_ADC1 #define STM32_ADC_USE_ADC1 TRUE -#undef STM32_PWM_USE_ADVANCED -#define STM32_PWM_USE_ADVANCED TRUE - #undef STM32_PWM_USE_TIM1 #define STM32_PWM_USE_TIM1 TRUE diff --git a/keyboards/meetlab/kalice/mcuconf.h b/keyboards/meetlab/kalice/mcuconf.h index e2f1a5652b9..92876625723 100644 --- a/keyboards/meetlab/kalice/mcuconf.h +++ b/keyboards/meetlab/kalice/mcuconf.h @@ -19,5 +19,3 @@ #undef STM32_PWM_USE_TIM1 #define STM32_PWM_USE_TIM1 TRUE -#undef STM32_PWM_USE_ADVANCED -#define STM32_PWM_USE_ADVANCED TRUE \ No newline at end of file diff --git a/keyboards/mode/m256wh/mcuconf.h b/keyboards/mode/m256wh/mcuconf.h index 3d1d05c307c..ff2280716d6 100644 --- a/keyboards/mode/m256wh/mcuconf.h +++ b/keyboards/mode/m256wh/mcuconf.h @@ -18,8 +18,5 @@ #include_next -#undef STM32_PWM_USE_ADVANCED -#define STM32_PWM_USE_ADVANCED TRUE - #undef STM32_PWM_USE_TIM1 #define STM32_PWM_USE_TIM1 TRUE diff --git a/keyboards/mode/m256ws/mcuconf.h b/keyboards/mode/m256ws/mcuconf.h index 3d1d05c307c..ff2280716d6 100644 --- a/keyboards/mode/m256ws/mcuconf.h +++ b/keyboards/mode/m256ws/mcuconf.h @@ -18,8 +18,5 @@ #include_next -#undef STM32_PWM_USE_ADVANCED -#define STM32_PWM_USE_ADVANCED TRUE - #undef STM32_PWM_USE_TIM1 #define STM32_PWM_USE_TIM1 TRUE diff --git a/keyboards/smithrune/iron165r2/f411/mcuconf.h b/keyboards/smithrune/iron165r2/f411/mcuconf.h index 63f1e30e641..c35579fe1c7 100644 --- a/keyboards/smithrune/iron165r2/f411/mcuconf.h +++ b/keyboards/smithrune/iron165r2/f411/mcuconf.h @@ -21,9 +21,6 @@ #undef STM32_I2C_USE_I2C1 #define STM32_I2C_USE_I2C1 TRUE -#undef STM32_PWM_USE_ADVANCED -#define STM32_PWM_USE_ADVANCED TRUE - #undef STM32_PWM_USE_TIM3 #define STM32_PWM_USE_TIM3 TRUE diff --git a/keyboards/smithrune/magnus/m75h/mcuconf.h b/keyboards/smithrune/magnus/m75h/mcuconf.h index 8f4541a8c39..e9e60c9f990 100644 --- a/keyboards/smithrune/magnus/m75h/mcuconf.h +++ b/keyboards/smithrune/magnus/m75h/mcuconf.h @@ -18,9 +18,6 @@ #include_next -#undef STM32_PWM_USE_ADVANCED -#define STM32_PWM_USE_ADVANCED TRUE - #undef STM32_PWM_USE_TIM3 #define STM32_PWM_USE_TIM3 TRUE diff --git a/keyboards/smithrune/magnus/m75s/mcuconf.h b/keyboards/smithrune/magnus/m75s/mcuconf.h index 8f4541a8c39..e9e60c9f990 100644 --- a/keyboards/smithrune/magnus/m75s/mcuconf.h +++ b/keyboards/smithrune/magnus/m75s/mcuconf.h @@ -18,9 +18,6 @@ #include_next -#undef STM32_PWM_USE_ADVANCED -#define STM32_PWM_USE_ADVANCED TRUE - #undef STM32_PWM_USE_TIM3 #define STM32_PWM_USE_TIM3 TRUE diff --git a/keyboards/tg67/mcuconf.h b/keyboards/tg67/mcuconf.h index 8d8fd085d42..a4bf617885a 100644 --- a/keyboards/tg67/mcuconf.h +++ b/keyboards/tg67/mcuconf.h @@ -20,6 +20,3 @@ #undef STM32_PWM_USE_TIM1 #define STM32_PWM_USE_TIM1 TRUE - -#undef STM32_PWM_USE_ADVANCED -#define STM32_PWM_USE_ADVANCED TRUE diff --git a/keyboards/viendi8l/mcuconf.h b/keyboards/viendi8l/mcuconf.h index 6c8d8c8af97..c9aae5b9e5e 100644 --- a/keyboards/viendi8l/mcuconf.h +++ b/keyboards/viendi8l/mcuconf.h @@ -21,8 +21,5 @@ #undef STM32_I2C_USE_I2C1 #define STM32_I2C_USE_I2C1 TRUE -#undef STM32_PWM_USE_ADVANCED -#define STM32_PWM_USE_ADVANCED TRUE - #undef STM32_PWM_USE_TIM1 #define STM32_PWM_USE_TIM1 TRUE diff --git a/platforms/chibios/drivers/backlight_pwm.c b/platforms/chibios/drivers/backlight_pwm.c index 01e6f71307a..25fe7962b02 100644 --- a/platforms/chibios/drivers/backlight_pwm.c +++ b/platforms/chibios/drivers/backlight_pwm.c @@ -25,7 +25,7 @@ # define BACKLIGHT_PWM_CHANNEL 3 #endif -// Support for pins which are on TIM1_CH1N - requires STM32_PWM_USE_ADVANCED +// Support for pins which are on TIM1_CH1N #ifdef BACKLIGHT_PWM_COMPLEMENTARY_OUTPUT # if BACKLIGHT_ON_STATE == 1 # define PWM_OUTPUT_MODE PWM_COMPLEMENTARY_OUTPUT_ACTIVE_LOW;