From 088f0774070bdc09f7e6917aa70ef158c1ac5806 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Fournier?= Date: Sun, 8 Dec 2019 14:15:59 +0100 Subject: [PATCH] Deprecate AbstractJavaParser Internalize JavaLanguageParser --- .../net/sourceforge/pmd/lang/java/AbstractJavaParser.java | 3 +++ .../net/sourceforge/pmd/lang/java/JavaLanguageParser.java | 6 ++++++ 2 files changed, 9 insertions(+) diff --git a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/AbstractJavaParser.java b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/AbstractJavaParser.java index d153760370..1e7ef921a4 100644 --- a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/AbstractJavaParser.java +++ b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/AbstractJavaParser.java @@ -23,7 +23,10 @@ import net.sourceforge.pmd.lang.java.ast.ParseException; * * @see AbstractParser * @see JavaParser + * + * @deprecated For removal, the abstraction is not useful. */ +@Deprecated public abstract class AbstractJavaParser extends AbstractParser { private JavaParser parser; diff --git a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/JavaLanguageParser.java b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/JavaLanguageParser.java index e259617e0b..1d29702be7 100644 --- a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/JavaLanguageParser.java +++ b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/JavaLanguageParser.java @@ -6,6 +6,8 @@ package net.sourceforge.pmd.lang.java; import java.io.Reader; +import net.sourceforge.pmd.annotation.InternalApi; +import net.sourceforge.pmd.lang.LanguageVersionHandler; import net.sourceforge.pmd.lang.ParserOptions; import net.sourceforge.pmd.lang.java.ast.JavaParser; import net.sourceforge.pmd.lang.java.ast.ParseException; @@ -15,7 +17,11 @@ import net.sourceforge.pmd.lang.java.ast.ParseException; * * @author Pieter_Van_Raemdonck - Application Engineers NV/SA - www.ae.be * @author Andreas Dangel + * + * @deprecated This is internal API, use {@link LanguageVersionHandler#getParser(ParserOptions)}. */ +@InternalApi +@Deprecated public class JavaLanguageParser extends AbstractJavaParser { private final int jdkVersion; private final boolean preview;