From 0bca478e31ea251b3ec987a357358ad4a85e7d0a Mon Sep 17 00:00:00 2001
From: Andreas Dangel <adangel@users.sourceforge.net>
Date: Sat, 15 Nov 2014 17:02:50 +0100
Subject: [PATCH] #1282 False Positive with implicit String.valuesOf() (Java)

---
 .../main/resources/rulesets/java/unnecessary.xml |  4 +++-
 .../rule/unnecessary/xml/UselessParentheses.xml  | 16 ++++++++++++++++
 src/site/markdown/overview/changelog.md          |  1 +
 3 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/pmd-java/src/main/resources/rulesets/java/unnecessary.xml b/pmd-java/src/main/resources/rulesets/java/unnecessary.xml
index 7551494a0f..ab7ae2abd9 100644
--- a/pmd-java/src/main/resources/rulesets/java/unnecessary.xml
+++ b/pmd-java/src/main/resources/rulesets/java/unnecessary.xml
@@ -220,7 +220,9 @@ public class Test {
        <property name="xpath">
           <value>
           <![CDATA[
-//Expression/PrimaryExpression/PrimaryPrefix/Expression[count(*)=1 and count(./CastExpression)=0 and count(./ConditionalExpression[@Ternary='true'])=0]
+//Expression/PrimaryExpression/PrimaryPrefix/Expression
+[count(*)=1][count(./CastExpression)=0][count(./ConditionalExpression[@Ternary='true'])=0]
+[not(./AdditiveExpression[//Literal[@StringLiteral='true']])]
 |
 //Expression/ConditionalAndExpression/PrimaryExpression/PrimaryPrefix/Expression[
     count(*)=1 and
diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/unnecessary/xml/UselessParentheses.xml b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/unnecessary/xml/UselessParentheses.xml
index 9b69c8300c..2a01e47b83 100644
--- a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/unnecessary/xml/UselessParentheses.xml
+++ b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/unnecessary/xml/UselessParentheses.xml
@@ -224,6 +224,22 @@ public class Test {
     public static int thisShouldBreak(final int x, final int y, final int z) {
         return x - (y + z);
     }
+}
+        ]]></code>
+    </test-code>
+    <test-code>
+        <description>#1282 False Positive with implicit String.valuesOf() (Java)</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+package com.mycompany.mavenproject1;
+
+import java.io.IOException;
+
+public class NewClass {
+
+    public void falsePositive(Boolean b) throws IOException {
+        System.out.write(( "" + b ).getBytes());
+    }
 }
         ]]></code>
     </test-code>
diff --git a/src/site/markdown/overview/changelog.md b/src/site/markdown/overview/changelog.md
index 6a5ca8df82..a4965d9cd7 100644
--- a/src/site/markdown/overview/changelog.md
+++ b/src/site/markdown/overview/changelog.md
@@ -12,3 +12,4 @@
 
 * [#1276](https://sourceforge.net/p/pmd/bugs/1276/): False positive in UnusedPrivateMethod with inner enum
 * [#1281](https://sourceforge.net/p/pmd/bugs/1281/): UnusedPrivateMethod incorrectly flagged for methods nested private classes
+* [#1282](https://sourceforge.net/p/pmd/bugs/1282/): False Positive with implicit String.valuesOf() (Java)