From 13cc79af62d060bff491ff33cddf918cad0cb6ae Mon Sep 17 00:00:00 2001
From: Andreas Dangel <andreas.dangel@pmd-code.org>
Date: Sat, 5 Oct 2024 10:36:39 +0200
Subject: [PATCH] [java] TooFewBranchesForSwitch - also ignore record pattern

---
 .../resources/category/java/performance.xml    |  2 +-
 .../xml/TooFewBranchesForSwitch.xml            | 18 +++++++++++++++++-
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/pmd-java/src/main/resources/category/java/performance.xml b/pmd-java/src/main/resources/category/java/performance.xml
index 4c0d2fe00c..2a6d218354 100644
--- a/pmd-java/src/main/resources/category/java/performance.xml
+++ b/pmd-java/src/main/resources/category/java/performance.xml
@@ -630,7 +630,7 @@ Note: This rule was named TooFewBranchesForASwitchStatement before PMD 7.7.0.
 <![CDATA[
 //(SwitchStatement | SwitchExpression)[ (count(*) - 1) < $minimumNumberCaseForASwitch ]
   (: exclude pattern matching :)
-  [not(*/SwitchLabel/TypePattern)]
+  [not(*/SwitchLabel/(TypePattern|RecordPattern))]
 ]]>
                 </value>
             </property>
diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/performance/xml/TooFewBranchesForSwitch.xml b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/performance/xml/TooFewBranchesForSwitch.xml
index 10dbb0081f..2af77f0e74 100644
--- a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/performance/xml/TooFewBranchesForSwitch.xml
+++ b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/performance/xml/TooFewBranchesForSwitch.xml
@@ -89,7 +89,7 @@ public class ValidSwitch {
     </test-code>
 
     <test-code>
-        <description>[java] TooFewBranchesForASwitchStatement false positive for Pattern Matching</description>
+        <description>[java] TooFewBranchesForASwitchStatement false positive for Pattern Matching #5249</description>
         <expected-problems>0</expected-problems>
         <code><![CDATA[
 sealed interface S permits A {}
@@ -107,6 +107,22 @@ public class Sample {
         };
     }
 }
+]]></code>
+    </test-code>
+
+    <test-code>
+        <description>Record patterns are ignored, too #5249</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+record R(int i) {}
+
+public class SwitchWithRecordPattern {
+    public void check(R r) {
+        switch(r) {
+            case R(int a) -> System.out.println(a);
+        }
+    }
+}
 ]]></code>
     </test-code>
 </test-data>