From 164825993b78fd33eb8f9a822112716b95407123 Mon Sep 17 00:00:00 2001 From: David Dixon-Peugh Date: Fri, 28 Jun 2002 18:38:17 +0000 Subject: [PATCH] Fixed no-method case. git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@135 51baf565-9d33-0410-a72c-fc3788e3496d --- .../net/sourceforge/pmd/rules/design/UseSingletonRule.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pmd/src/net/sourceforge/pmd/rules/design/UseSingletonRule.java b/pmd/src/net/sourceforge/pmd/rules/design/UseSingletonRule.java index dca65ff0f3..6008854b15 100644 --- a/pmd/src/net/sourceforge/pmd/rules/design/UseSingletonRule.java +++ b/pmd/src/net/sourceforge/pmd/rules/design/UseSingletonRule.java @@ -10,7 +10,8 @@ import net.sourceforge.pmd.ast.ASTMethodDeclaration; public class UseSingletonRule extends AbstractRule { - public boolean isOK = false; + private boolean isOK = false; + private int methodCount = 0; public UseSingletonRule() { } @@ -19,6 +20,7 @@ public class UseSingletonRule } public Object visit( ASTMethodDeclaration decl, Object data ) { + methodCount ++; if (isOK) return data; if (!decl.isStatic()) { @@ -32,7 +34,7 @@ public class UseSingletonRule Object RC = cu.childrenAccept( this, data ); - if (!isOK) { + if ((!isOK) && (methodCount > 0)) { (((RuleContext) data).getReport()). addRuleViolation( new RuleViolation( this, cu.getBeginLine() )); }