From 1fb085f7ab48ecafafeeaab1b5cd6760b4417ca5 Mon Sep 17 00:00:00 2001 From: Andreas Dangel Date: Fri, 3 Jul 2020 11:58:38 +0200 Subject: [PATCH] Use StringUtils.equalsIgnoreCase --- .../bestpractices/UnusedLocalVariableRule.java | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/bestpractices/UnusedLocalVariableRule.java b/pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/bestpractices/UnusedLocalVariableRule.java index 0a9cb4592a..04eb3cea4e 100644 --- a/pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/bestpractices/UnusedLocalVariableRule.java +++ b/pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/bestpractices/UnusedLocalVariableRule.java @@ -7,6 +7,8 @@ package net.sourceforge.pmd.lang.apex.rule.bestpractices; import java.util.ArrayList; import java.util.List; +import org.apache.commons.lang3.StringUtils; + import net.sourceforge.pmd.lang.apex.ast.ASTBlockStatement; import net.sourceforge.pmd.lang.apex.ast.ASTReferenceExpression; import net.sourceforge.pmd.lang.apex.ast.ASTVariableDeclaration; @@ -41,7 +43,7 @@ public class UnusedLocalVariableRule extends AbstractApexRule { continue; } - if (equalsIgnoreCase(variableName, usage.getImage())) { + if (StringUtils.equalsIgnoreCase(variableName, usage.getImage())) { return data; } } @@ -49,14 +51,4 @@ public class UnusedLocalVariableRule extends AbstractApexRule { addViolation(data, node, variableName); return data; } - - private static boolean equalsIgnoreCase(String a, String b) { - if (a == b) { - return true; - } - if (a == null || b == null) { - return false; - } - return a.equalsIgnoreCase(b); - } }