From 1fbc00927e119f114b6a053ef7a6c9596dc14311 Mon Sep 17 00:00:00 2001 From: Xavier Le Vourch Date: Tue, 20 Nov 2007 02:03:14 +0000 Subject: [PATCH] bug fix: create new log appender in applyLogPreferences() if configureLogs() didn't manage to set it earlier git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5665 51baf565-9d33-0410-a72c-fc3788e3496d --- .../net/sourceforge/pmd/runtime/PMDRuntimePlugin.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pmd-eclipse-plugin/pmd-eclipse-runtime/src/net/sourceforge/pmd/runtime/PMDRuntimePlugin.java b/pmd-eclipse-plugin/pmd-eclipse-runtime/src/net/sourceforge/pmd/runtime/PMDRuntimePlugin.java index 0229a438fb..2259f3d73e 100644 --- a/pmd-eclipse-plugin/pmd-eclipse-runtime/src/net/sourceforge/pmd/runtime/PMDRuntimePlugin.java +++ b/pmd-eclipse-plugin/pmd-eclipse-runtime/src/net/sourceforge/pmd/runtime/PMDRuntimePlugin.java @@ -94,7 +94,7 @@ public class PMDRuntimePlugin extends AbstractUIPlugin { */ public void start(BundleContext context) throws Exception { super.start(context); - configureLogs(); + configureLogs(loadPreferences()); } /** @@ -180,7 +180,9 @@ public class PMDRuntimePlugin extends AbstractUIPlugin { Logger log = Logger.getLogger(ROOT_LOG_ID); log.setLevel(preferences.getLogLevel()); RollingFileAppender appender = (RollingFileAppender) log.getAppender(PMD_ECLIPSE_APPENDER_NAME); - if (!appender.getFile().equals(preferences.getLogFileName())) { + if (appender == null) { + configureLogs(preferences); + } else if (!appender.getFile().equals(preferences.getLogFileName())) { appender.setFile(preferences.getLogFileName()); appender.activateOptions(); } @@ -190,10 +192,8 @@ public class PMDRuntimePlugin extends AbstractUIPlugin { * Configure the logging * */ - private void configureLogs() { + private void configureLogs(IPreferences preferences) { try { - IPreferences preferences = loadPreferences(); - Layout layout = new PatternLayout("%d{yyyy/MM/dd HH:mm:ss,SSS} %-5p %-32c{1} %m%n"); RollingFileAppender appender = new RollingFileAppender(layout, preferences.getLogFileName());