From 278e4f3414f3137dba11f3402a4aa3f57b50a623 Mon Sep 17 00:00:00 2001 From: Andreas Dangel Date: Thu, 13 Aug 2020 17:00:34 +0200 Subject: [PATCH] Fix pmd, add missing test classes for typeres --- .../lang/java/rule/performance/StringToStringRule.java | 3 +-- .../lang/java/rule/performance/stringtostring/Car.java | 9 +++++++++ .../lang/java/rule/performance/stringtostring/User.java | 9 +++++++++ 3 files changed, 19 insertions(+), 2 deletions(-) create mode 100644 pmd-java/src/test/java/net/sourceforge/pmd/lang/java/rule/performance/stringtostring/Car.java create mode 100644 pmd-java/src/test/java/net/sourceforge/pmd/lang/java/rule/performance/stringtostring/User.java diff --git a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/performance/StringToStringRule.java b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/performance/StringToStringRule.java index a41f33707d..bc19c3c919 100644 --- a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/performance/StringToStringRule.java +++ b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/performance/StringToStringRule.java @@ -285,8 +285,7 @@ public class StringToStringRule extends AbstractJavaRule { private Class getMethodReturnType(ASTMethodDeclaration method) { ASTType returnType = method != null ? method.getResultType().getFirstDescendantOfType(ASTType.class) : null; if (returnType != null) { - Class type = returnType.getType(); - return type; + return returnType.getType(); } return null; } diff --git a/pmd-java/src/test/java/net/sourceforge/pmd/lang/java/rule/performance/stringtostring/Car.java b/pmd-java/src/test/java/net/sourceforge/pmd/lang/java/rule/performance/stringtostring/Car.java new file mode 100644 index 0000000000..7eba268fcd --- /dev/null +++ b/pmd-java/src/test/java/net/sourceforge/pmd/lang/java/rule/performance/stringtostring/Car.java @@ -0,0 +1,9 @@ +/* + * BSD-style license; for more info see http://pmd.sourceforge.net/license.html + */ + +package net.sourceforge.pmd.lang.java.rule.performance.stringtostring; + +public class Car { + +} diff --git a/pmd-java/src/test/java/net/sourceforge/pmd/lang/java/rule/performance/stringtostring/User.java b/pmd-java/src/test/java/net/sourceforge/pmd/lang/java/rule/performance/stringtostring/User.java new file mode 100644 index 0000000000..309fc5eeee --- /dev/null +++ b/pmd-java/src/test/java/net/sourceforge/pmd/lang/java/rule/performance/stringtostring/User.java @@ -0,0 +1,9 @@ +/* + * BSD-style license; for more info see http://pmd.sourceforge.net/license.html + */ + +package net.sourceforge.pmd.lang.java.rule.performance.stringtostring; + +public class User { + +}