From 43ee63a50217f436a7b742ab5a9defe3978c4dfa Mon Sep 17 00:00:00 2001 From: Tom Copeland Date: Mon, 23 Sep 2002 14:48:39 +0000 Subject: [PATCH] removed unneeded constructors thanks to JUnit 3.8.1 upgrade git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@968 51baf565-9d33-0410-a72c-fc3788e3496d --- pmd/etc/changelog.txt | 1 + pmd/etc/cpdgui.bat | 2 +- .../test/net/sourceforge/pmd/NamespaceTest.java | 3 --- .../test/net/sourceforge/pmd/ReportTest.java | 4 ---- .../test/net/sourceforge/pmd/RuleContextTest.java | 3 --- .../net/sourceforge/pmd/RuleSetFactoryTest.java | 4 ---- .../net/sourceforge/pmd/RuleSetReadWriteTest.java | 13 +------------ .../test/net/sourceforge/pmd/RuleSetTest.java | 4 ---- .../test/net/sourceforge/pmd/RuleViolationTest.java | 8 -------- .../test/net/sourceforge/pmd/SymbolTableTest.java | 4 ---- .../test/net/sourceforge/pmd/SymbolTest.java | 4 ---- .../test/net/sourceforge/pmd/TypeSetTest.java | 3 --- 12 files changed, 3 insertions(+), 50 deletions(-) diff --git a/pmd/etc/changelog.txt b/pmd/etc/changelog.txt index 331625faa7..315af28b76 100644 --- a/pmd/etc/changelog.txt +++ b/pmd/etc/changelog.txt @@ -1,4 +1,5 @@ ???? 2002 - ???: +Modified PMD to be built and used with JUnit 3.8.1 and Ant 1.5. September 12 2002 - 1.0rc2: Added new rules: JUnitSpellingRule, JUnitStaticSuiteRule, StringInstantiationRule diff --git a/pmd/etc/cpdgui.bat b/pmd/etc/cpdgui.bat index 02e6ecf0e7..2ecc8b80e7 100755 --- a/pmd/etc/cpdgui.bat +++ b/pmd/etc/cpdgui.bat @@ -1,2 +1,2 @@ -set CLASSPATH=../lib/pmd-1.0rc1.jar +set CLASSPATH=../lib/pmd-1.0rc2.jar java net.sourceforge.pmd.cpd.GUI \ No newline at end of file diff --git a/pmd/regress/test/net/sourceforge/pmd/NamespaceTest.java b/pmd/regress/test/net/sourceforge/pmd/NamespaceTest.java index 6afe07e1a8..1de2933d50 100644 --- a/pmd/regress/test/net/sourceforge/pmd/NamespaceTest.java +++ b/pmd/regress/test/net/sourceforge/pmd/NamespaceTest.java @@ -10,9 +10,6 @@ import net.sourceforge.pmd.Namespace; import net.sourceforge.pmd.SymbolTable; public class NamespaceTest extends TestCase{ - public NamespaceTest(String name) { - super(name); - } public void testBasic() { Namespace nameSpace = new Namespace(); diff --git a/pmd/regress/test/net/sourceforge/pmd/ReportTest.java b/pmd/regress/test/net/sourceforge/pmd/ReportTest.java index 4ec0156590..af9c6b2412 100644 --- a/pmd/regress/test/net/sourceforge/pmd/ReportTest.java +++ b/pmd/regress/test/net/sourceforge/pmd/ReportTest.java @@ -24,10 +24,6 @@ public class ReportTest extends TestCase implements ReportListener { private boolean violationSemaphore; private boolean metricSemaphore; - public ReportTest(String name) { - super(name); - } - public void testBasic() { Report r = new Report(); r.addRuleViolation(new RuleViolation(new MockRule(), 5, "foo")); diff --git a/pmd/regress/test/net/sourceforge/pmd/RuleContextTest.java b/pmd/regress/test/net/sourceforge/pmd/RuleContextTest.java index 1e050999fd..82234362cc 100644 --- a/pmd/regress/test/net/sourceforge/pmd/RuleContextTest.java +++ b/pmd/regress/test/net/sourceforge/pmd/RuleContextTest.java @@ -11,9 +11,6 @@ import net.sourceforge.pmd.Report; import net.sourceforge.pmd.renderers.Renderer; public class RuleContextTest extends TestCase { - public RuleContextTest(String name) { - super(name); - } public void testReport() { RuleContext ctx = new RuleContext(); diff --git a/pmd/regress/test/net/sourceforge/pmd/RuleSetFactoryTest.java b/pmd/regress/test/net/sourceforge/pmd/RuleSetFactoryTest.java index 7b4e47ac21..10f26bc77c 100644 --- a/pmd/regress/test/net/sourceforge/pmd/RuleSetFactoryTest.java +++ b/pmd/regress/test/net/sourceforge/pmd/RuleSetFactoryTest.java @@ -76,10 +76,6 @@ public class RuleSetFactoryTest extends TestCase { "" + EOL + ""; - public RuleSetFactoryTest(String name) { - super(name); - } - public void testRuleSetNotFound() { RuleSetFactory rsf = new RuleSetFactory(); try { diff --git a/pmd/regress/test/net/sourceforge/pmd/RuleSetReadWriteTest.java b/pmd/regress/test/net/sourceforge/pmd/RuleSetReadWriteTest.java index 1af8e7fa14..85b84f4970 100644 --- a/pmd/regress/test/net/sourceforge/pmd/RuleSetReadWriteTest.java +++ b/pmd/regress/test/net/sourceforge/pmd/RuleSetReadWriteTest.java @@ -31,17 +31,6 @@ public class RuleSetReadWriteTest extends TestCase private RuleSet m_ruleSetIn; private RuleSet m_ruleSetOut; - /** - ******************************************************************************** - * - * @param name - */ - public RuleSetReadWriteTest(String name) - { - super(name); - - } - /** ******************************************************************************** * @@ -163,6 +152,6 @@ public class RuleSetReadWriteTest extends TestCase */ public static void main(String[] args) { - (new RuleSetReadWriteTest("")).testReadWrite(); + (new RuleSetReadWriteTest()).testReadWrite(); } } diff --git a/pmd/regress/test/net/sourceforge/pmd/RuleSetTest.java b/pmd/regress/test/net/sourceforge/pmd/RuleSetTest.java index 42eb9e7946..78ae37561a 100644 --- a/pmd/regress/test/net/sourceforge/pmd/RuleSetTest.java +++ b/pmd/regress/test/net/sourceforge/pmd/RuleSetTest.java @@ -21,10 +21,6 @@ public class RuleSetTest extends TestCase private String javaCode = "public class Test { }"; - public RuleSetTest( String name ) { - super( name ); - } - public void testConstructor() { RuleSet IUT = new RuleSet(); } diff --git a/pmd/regress/test/net/sourceforge/pmd/RuleViolationTest.java b/pmd/regress/test/net/sourceforge/pmd/RuleViolationTest.java index d52b7eafa6..c182d27dac 100644 --- a/pmd/regress/test/net/sourceforge/pmd/RuleViolationTest.java +++ b/pmd/regress/test/net/sourceforge/pmd/RuleViolationTest.java @@ -7,9 +7,6 @@ import net.sourceforge.pmd.Rule; import net.sourceforge.pmd.RuleViolation; public class RuleViolationTest extends TestCase { - public RuleViolationTest(String name) { - super(name); - } public void testConstructor1() { Rule rule = new MockRule("name", "desc"); @@ -28,11 +25,6 @@ public class RuleViolationTest extends TestCase { assertEquals("description", r.getDescription()); } - // - // Changed logic of Comparator so that rules in the same file - // get grouped together in the output report. - // DDP 7/11/2002 - // public void testComparatorWithDifferentFilenames() { Rule rule = new MockRule("name", "desc"); RuleViolation.RuleViolationComparator comp = new RuleViolation.RuleViolationComparator(); diff --git a/pmd/regress/test/net/sourceforge/pmd/SymbolTableTest.java b/pmd/regress/test/net/sourceforge/pmd/SymbolTableTest.java index 49b65ee22a..592107c88f 100644 --- a/pmd/regress/test/net/sourceforge/pmd/SymbolTableTest.java +++ b/pmd/regress/test/net/sourceforge/pmd/SymbolTableTest.java @@ -15,10 +15,6 @@ public class SymbolTableTest extends TestCase { private static final Symbol FOO = new Symbol("foo", 10); - public SymbolTableTest(String name) { - super(name); - } - public void testAdd() { SymbolTable s = new SymbolTable(); s.add(FOO); diff --git a/pmd/regress/test/net/sourceforge/pmd/SymbolTest.java b/pmd/regress/test/net/sourceforge/pmd/SymbolTest.java index 1ab311c559..3f0de5f68d 100644 --- a/pmd/regress/test/net/sourceforge/pmd/SymbolTest.java +++ b/pmd/regress/test/net/sourceforge/pmd/SymbolTest.java @@ -10,10 +10,6 @@ import net.sourceforge.pmd.Symbol; public class SymbolTest extends TestCase { - public SymbolTest(String name) { - super(name); - } - public void testBasic() { Symbol s = new Symbol("foo", 10); assertEquals(10, s.getLine()); diff --git a/pmd/regress/test/net/sourceforge/pmd/TypeSetTest.java b/pmd/regress/test/net/sourceforge/pmd/TypeSetTest.java index 078f4c4ce1..e8fc345bf7 100644 --- a/pmd/regress/test/net/sourceforge/pmd/TypeSetTest.java +++ b/pmd/regress/test/net/sourceforge/pmd/TypeSetTest.java @@ -14,9 +14,6 @@ import java.util.Set; import java.util.HashSet; public class TypeSetTest extends TestCase { - public TypeSetTest(String name) { - super(name); - } public void testASTCompilationUnitPackage() { TypeSet t = new TypeSet();