From 45030e0743a65d1aca373bf56262d3369310a5d2 Mon Sep 17 00:00:00 2001
From: Philippe Herlin <phherlin@users.sourceforge.net>
Date: Wed, 15 Jun 2005 21:16:27 +0000
Subject: [PATCH] Create a plugin fragment for the Eclipse plugin unit tests

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@3587 51baf565-9d33-0410-a72c-fc3788e3496d
---
 pmd-eclipse-test-fragment/.classpath          |   7 +
 pmd-eclipse-test-fragment/.project            |  28 +
 pmd-eclipse-test-fragment/build.properties    |   4 +
 pmd-eclipse-test-fragment/fragment.xml        |  18 +
 .../src/rulesets/additional                   |   2 +
 .../src/rulesets/extra1.xml                   | 616 ++++++++++++++++++
 .../src/rulesets/extra2.xml                   | 129 ++++
 7 files changed, 804 insertions(+)
 create mode 100644 pmd-eclipse-test-fragment/.classpath
 create mode 100644 pmd-eclipse-test-fragment/.project
 create mode 100644 pmd-eclipse-test-fragment/build.properties
 create mode 100644 pmd-eclipse-test-fragment/fragment.xml
 create mode 100644 pmd-eclipse-test-fragment/src/rulesets/additional
 create mode 100644 pmd-eclipse-test-fragment/src/rulesets/extra1.xml
 create mode 100644 pmd-eclipse-test-fragment/src/rulesets/extra2.xml

diff --git a/pmd-eclipse-test-fragment/.classpath b/pmd-eclipse-test-fragment/.classpath
new file mode 100644
index 0000000000..065ac06e19
--- /dev/null
+++ b/pmd-eclipse-test-fragment/.classpath
@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<classpath>
+	<classpathentry kind="src" path="src"/>
+	<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
+	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER"/>
+	<classpathentry kind="output" path="bin"/>
+</classpath>
diff --git a/pmd-eclipse-test-fragment/.project b/pmd-eclipse-test-fragment/.project
new file mode 100644
index 0000000000..c8e9ac9d78
--- /dev/null
+++ b/pmd-eclipse-test-fragment/.project
@@ -0,0 +1,28 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<projectDescription>
+	<name>pmd-eclipse-test-fragment</name>
+	<comment></comment>
+	<projects>
+	</projects>
+	<buildSpec>
+		<buildCommand>
+			<name>org.eclipse.jdt.core.javabuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+		<buildCommand>
+			<name>org.eclipse.pde.ManifestBuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+		<buildCommand>
+			<name>org.eclipse.pde.SchemaBuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+	</buildSpec>
+	<natures>
+		<nature>org.eclipse.pde.PluginNature</nature>
+		<nature>org.eclipse.jdt.core.javanature</nature>
+	</natures>
+</projectDescription>
diff --git a/pmd-eclipse-test-fragment/build.properties b/pmd-eclipse-test-fragment/build.properties
new file mode 100644
index 0000000000..9ba6a0771c
--- /dev/null
+++ b/pmd-eclipse-test-fragment/build.properties
@@ -0,0 +1,4 @@
+source.pmd_eclipse_test_fragment.jar = src/
+output.pmd_eclipse_test_fragment.jar = bin/
+bin.includes = fragment.xml,\
+               pmd_eclipse_test_fragment.jar
diff --git a/pmd-eclipse-test-fragment/fragment.xml b/pmd-eclipse-test-fragment/fragment.xml
new file mode 100644
index 0000000000..3f51d8b60c
--- /dev/null
+++ b/pmd-eclipse-test-fragment/fragment.xml
@@ -0,0 +1,18 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<?eclipse version="3.0"?>
+<fragment
+   id="pmd_eclipse_test_fragment"
+   name="Pmd_eclipse_test_fragment Fragment"
+   version="1.0.0"
+   provider-name=""
+   plugin-id="net.sourceforge.pmd.core"
+   plugin-version="3.1.0"
+   match="greaterOrEqual">
+
+   <runtime>
+      <library name="pmd_eclipse_test_fragment.jar">
+         <export name="*"/>
+      </library>
+   </runtime>
+
+</fragment>
diff --git a/pmd-eclipse-test-fragment/src/rulesets/additional b/pmd-eclipse-test-fragment/src/rulesets/additional
new file mode 100644
index 0000000000..9757baa0ee
--- /dev/null
+++ b/pmd-eclipse-test-fragment/src/rulesets/additional
@@ -0,0 +1,2 @@
+rulesets/extra1.xml
+rulesets/extra2.xml
diff --git a/pmd-eclipse-test-fragment/src/rulesets/extra1.xml b/pmd-eclipse-test-fragment/src/rulesets/extra1.xml
new file mode 100644
index 0000000000..5449939323
--- /dev/null
+++ b/pmd-eclipse-test-fragment/src/rulesets/extra1.xml
@@ -0,0 +1,616 @@
+<?xml version="1.0"?>
+
+<ruleset name="Extra Rules 1" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:noNamespaceSchemaLocation="../etc/ruleset_xml_schema.xml">
+  <description>
+The Basic Ruleset contains a collection of good practices which everyone should follow.
+  </description>
+
+
+    <rule name="EmptyCatchBlock"
+          message="Avoid empty catch blocks"
+          class="net.sourceforge.pmd.rules.XPathRule">
+      <description>
+  Empty Catch Block finds instances where an exception is caught,
+  but nothing is done.  In most circumstances, this swallows an exception
+  which should either be acted on or reported.
+      </description>
+      <properties>
+          <property name="xpath">
+              <value>
+    <![CDATA[
+    //TryStatement
+    [@Catch='true']
+    [FormalParameter/Type/ReferenceType/ClassOrInterfaceType
+     [@Image != 'InterruptedException' and @Image != 'CloneNotSupportedException']
+    ]
+    /Block[position() > 1]
+    [count(*) = 0]
+    [../@Finally='false' or following-sibling::Block]
+ ]]>
+              </value>
+          </property>
+      </properties>
+        <priority>3</priority>
+
+      <example>
+  <![CDATA[public void doSomething() {
+      try {
+        FileInputStream fis = new FileInputStream("/tmp/bugger");
+      } catch (IOException ioe) {
+          // not good
+      }
+    }]]>
+      </example>
+    </rule>
+
+    <rule name="EmptyIfStmt"
+          message="Avoid empty 'if' statements"
+          class="net.sourceforge.pmd.rules.XPathRule">
+      <description>
+  Empty If Statement finds instances where a condition is checked but nothing is done about it.
+    </description>
+        <priority>3</priority>
+      <properties>
+          <property name="xpath">
+              <value>
+                  <![CDATA[//IfStatement/Statement/Block[count(*) = 0]]]>
+              </value>
+          </property>
+      </properties>
+      <example>
+    <![CDATA[if (foo == 0) {
+       // why bother checking up on foo?
+    }]]>
+       </example>
+    </rule>
+
+
+    <rule name="EmptyWhileStmt"
+          message="Avoid empty 'while' statements"
+          class="net.sourceforge.pmd.rules.XPathRule">
+       <description>
+  Empty While Statement finds all instances where a while statement
+  does nothing.  If it is a timing loop, then you should use Thread.sleep() for it; if
+  it's a while loop that does a lot in the exit expression, rewrite it to make it clearer.
+       </description>
+      <properties>
+          <property name="xpath">
+              <value>
+                  <![CDATA[
+                  //WhileStatement/Statement[./Block[count(*) = 0]  or ./EmptyStatement]
+                  ]]>
+              </value>
+          </property>
+      </properties>
+        <priority>3</priority>
+
+       <example>
+  <![CDATA[while (a == b) {
+    // not good
+  }]]>
+       </example>
+    </rule>
+
+
+    <rule name="EmptyTryBlock"
+          message="Avoid empty try blocks"
+          class="net.sourceforge.pmd.rules.XPathRule">
+      <description>
+  Avoid empty try blocks - what's the point?
+      </description>
+      <properties>
+          <property name="xpath">
+              <value>
+                  <![CDATA[//TryStatement/Block[1][count(*) = 0]]]>
+              </value>
+          </property>
+      </properties>
+        <priority>3</priority>
+
+      <example>
+  <![CDATA[// this is bad
+  public void bar() {
+      try {
+      } catch (Exception e) {
+          e.printStackTrace();
+      }
+  }]]>
+      </example>
+    </rule>
+
+    <rule name="EmptyFinallyBlock"
+          message="Avoid empty finally blocks"
+          class="net.sourceforge.pmd.rules.XPathRule">
+      <description>
+  Avoid empty finally blocks - these can be deleted.
+      </description>
+      <properties>
+          <property name="xpath">
+              <value>
+                  <![CDATA[//TryStatement[@Finally='true']/Block[position() = last()]
+      [count(*) = 0]]]>
+              </value>
+          </property>
+      </properties>
+        <priority>3</priority>
+
+      <example>
+  <![CDATA[// this is bad
+  public void bar() {
+      try {
+          int x=2;
+      } finally {
+      }
+  }]]>
+      </example>
+    </rule>
+
+
+    <rule name="EmptySwitchStatements"
+          message="Avoid empty switch statements"
+          class="net.sourceforge.pmd.rules.XPathRule">
+      <description>
+      Avoid empty switch statements.
+      </description>
+      <properties>
+          <property name="xpath">
+              <value>
+                  <![CDATA[//SwitchStatement[count(*) = 1]]]>
+              </value>
+          </property>
+      </properties>
+        <priority>3</priority>
+
+      <example>
+  <![CDATA[public class Foo {
+   public void bar() {
+    int x = 2;
+    switch (x) {
+     // once there was code here
+     // but it's been commented out or something
+    }
+   }
+  }]]>
+      </example>
+      </rule>
+
+
+    <rule name="JumbledIncrementer"
+         message="Avoid modifying an outer loop incrementer in an inner loop for update expression"
+         class="net.sourceforge.pmd.rules.XPathRule">
+     <description>
+     Avoid jumbled loop incrementers - it's usually a mistake, and it's confusing even if it's what's intended.
+     </description>
+     <properties>
+         <property name="xpath">
+             <value>
+ <![CDATA[//ForStatement
+ [
+  ForUpdate/StatementExpressionList/StatementExpression/PostfixExpression/PrimaryExpression/PrimaryPrefix/Name/@Image
+  =
+  ancestor::ForStatement/ForInit//VariableDeclaratorId/@Image
+ ]]]>
+             </value>
+         </property>
+     </properties>
+        <priority>3</priority>
+
+     <example>
+ <![CDATA[public class JumbledIncrementerRule1 {
+  public void foo() {
+   for (int i = 0; i < 10; i++) {
+    for (int k = 0; k < 20; i++) {
+     System.out.println("Hello");
+    }
+   }
+  }
+ }]]>
+     </example>
+     </rule>
+
+
+    <rule name="ForLoopShouldBeWhileLoop"
+          message="This for loop could be simplified to a while loop"
+          class="net.sourceforge.pmd.rules.XPathRule">
+      <description>
+      Some for loops can be simplified to while loops - this makes them more concise.
+      </description>
+    <properties>
+        <property name="xpath">
+            <value>
+                <![CDATA[
+ //ForStatement
+  [count(*) > 1]
+  [not(ForInit)]
+  [not(ForUpdate)]
+  [not(Type and Expression and Statement)]
+ ]]>
+            </value>
+        </property>
+    </properties>
+        <priority>3</priority>
+      <example>
+  <![CDATA[public class Foo {
+      void bar() {
+          for (;true;) true; // No Init or Update part, may as well be: while (true)
+      }
+  }]]>
+      </example>
+    </rule>
+
+
+    <rule name="UnnecessaryConversionTemporary"
+          message="Avoid unnecessary temporaries when converting primitives to Strings"
+          class="net.sourceforge.pmd.rules.UnnecessaryConversionTemporary">
+      <description>
+      Avoid unnecessary temporaries when converting primitives to Strings
+      </description>
+        <priority>3</priority>
+      <example>
+  <![CDATA[public String convert(int x) {
+      // this wastes an object
+      String foo = new Integer(x).toString();
+      // this is better
+      return Integer.toString(x);
+    }]]>
+      </example>
+    </rule>
+
+    <rule name="OverrideBothEqualsAndHashcode"
+          message="Ensure you override both equals() and hashCode()"
+          class="net.sourceforge.pmd.rules.XPathRule">
+      <description>
+  Override both public boolean Object.equals(Object other), and public int Object.hashCode(), or override neither.  Even if you are inheriting a hashCode() from a parent class, consider implementing hashCode and explicitly delegating to your superclass.
+      </description>
+      <properties>
+          <property name="xpath">
+              <value>
+<![CDATA[
+//ClassOrInterfaceDeclaration[@Interface='false']//MethodDeclarator
+[(@Image = 'equals' and count(FormalParameters/*) = 1
+and not(//MethodDeclarator[count(FormalParameters/*) = 0][@Image = 'hashCode']))
+or
+(@Image='hashCode' and count(FormalParameters/*) = 0
+and
+not
+(//MethodDeclarator
+ [count(
+   FormalParameters//Type/ReferenceType/ClassOrInterfaceType
+    [@Image = 'Object' or @Image = 'java.lang.Object']) = 1]
+    [@Image = 'equals']))]
+ ]]>
+              </value>
+          </property>
+      </properties>
+        <priority>3</priority>
+
+      <example>
+  <![CDATA[// this is bad
+  public class Bar {
+      public boolean equals(Object o) {
+          // do some comparison
+      }
+  }
+
+  // and so is this
+  public class Baz {
+      public int hashCode() {
+          // return some hash value
+      }
+  }
+
+  // this is OK
+  public class Foo {
+      public boolean equals(Object other) {
+          // do some comparison
+      }
+      public int hashCode() {
+          // return some hash value
+      }
+  }]]>
+      </example>
+    </rule>
+
+    <rule name="DoubleCheckedLocking"
+          message="Double checked locking is not thread safe in Java."
+          class="net.sourceforge.pmd.rules.DoubleCheckedLocking">
+      <description>
+      Partially created objects can be returned by the Double Checked Locking pattern when used in Java.
+      An optimizing JRE may assign a reference to the baz variable before it creates the object the
+          reference is intended to point to.  For more details see http://www.javaworld.com/javaworld/jw-02-2001/jw-0209-double.html.
+      </description>
+        <priority>1</priority>
+      <example>
+  <![CDATA[public class Foo {
+      Object baz;
+      Object bar() {
+        if(baz == null) { //baz may be non-null yet not fully created
+          synchronized(this){
+            if(baz == null){
+              baz = new Object();
+            }
+          }
+        }
+        return baz;
+      }
+  }]]>
+      </example>
+    </rule>
+
+    <rule name="ReturnFromFinallyBlock"
+          message="Avoid returning from a finally block"
+          class="net.sourceforge.pmd.rules.XPathRule">
+      <description>
+  Avoid returning from a finally block - this can discard exceptions.
+      </description>
+      <properties>
+          <property name="xpath">
+              <value>
+                  <![CDATA[//TryStatement[@Finally='true']/Block[position() = last()]//ReturnStatement]]>
+              </value>
+          </property>
+      </properties>
+        <priority>3</priority>
+
+      <example>
+  <![CDATA[public class Bar {
+ public String bugga() {
+  try {
+   throw new Exception( "My Exception" );
+  } catch (Exception e) {
+   throw e;
+  } finally {
+   return "A. O. K."; // Very bad.
+  }
+ }
+}]]>
+      </example>
+    </rule>
+
+    <rule name="EmptySynchronizedBlock"
+          message="Avoid empty synchronized blocks"
+          class="net.sourceforge.pmd.rules.XPathRule">
+      <description>
+  Avoid empty synchronized blocks - they're useless.
+      </description>
+      <properties>
+          <property name="xpath">
+              <value>
+                  <![CDATA[//SynchronizedStatement/Block[1][count(*) = 0]]]>
+              </value>
+          </property>
+      </properties>
+        <priority>3</priority>
+
+      <example>
+  <![CDATA[// this is bad
+  public void bar() {
+      synchronized (this) {}
+  }]]>
+      </example>
+    </rule>
+
+    <rule name="UnnecessaryReturn"
+          message="Avoid unnecessary return statements"
+          class="net.sourceforge.pmd.rules.XPathRule">
+      <description>
+  Avoid unnecessary return statements
+      </description>
+      <properties>
+          <property name="xpath">
+              <value>
+ <![CDATA[//ReturnStatement
+ [parent::Statement
+  [parent::BlockStatement
+   [parent::Block
+    [parent::MethodDeclaration/ResultType[@Void='true']
+    ]
+   ]
+  ] ]]>
+              </value>
+          </property>
+      </properties>
+        <priority>3</priority>
+
+      <example>
+  <![CDATA[// this is bad
+  public void bar() {
+      int x = 42;
+      return;
+  }]]>
+      </example>
+    </rule>
+
+
+    <rule name="EmptyStaticInitializer"
+           message="Empty static initializer was found"
+           class="net.sourceforge.pmd.rules.XPathRule">
+       <description>
+       An empty static initializer was found.
+       </description>
+         <properties>
+             <property name="xpath">
+                 <value>
+<![CDATA[//ClassOrInterfaceBodyDeclaration/Initializer[@Static='true']/Block[count(*)=0]]]>
+                 </value>
+             </property>
+         </properties>
+         <priority>3</priority>
+       <example>
+   <![CDATA[public class Foo {
+  // why are there no statements in this static block?
+  static {}
+ }]]>
+       </example>
+     </rule>
+
+    <rule name="UnconditionalIfStatement"
+       message="Do not use 'if' statements that are always true or always false"
+          class="net.sourceforge.pmd.rules.XPathRule">
+      <description>
+      Do not use "if" statements that are always true or always false.
+      </description>
+        <properties>
+            <property name="xpath">
+                <value>
+ <![CDATA[//IfStatement/Expression
+ [count(PrimaryExpression)=1]
+ /PrimaryExpression/PrimaryPrefix/Literal/BooleanLiteral]]>
+                </value>
+            </property>
+        </properties>
+        <priority>3</priority>
+      <example>
+  <![CDATA[public class Foo {
+ public void close() {
+  if (true) {
+       // ...
+   }
+ }
+}]]>
+      </example>
+    </rule>
+
+    <rule name="EmptyStatementNotInLoop"
+          message="An empty statement (semicolon) not part of a loop"
+          class="net.sourceforge.pmd.rules.XPathRule">
+       <description>
+       An empty statement (aka a semicolon by itself) that is not used
+       as the sole body of a for loop or while loop is probably a bug.  It
+       could also be a double semicolon, which is useless and should be
+       removed.
+       </description>
+        <properties>
+            <property name="xpath">
+                <value>
+<![CDATA[
+//Statement/EmptyStatement
+ [not(
+       ../../../ForStatement
+       or ../../../WhileStatement
+       or ../../../BlockStatement/ClassOrInterfaceDeclaration
+       or ../../../../../../ForStatement/Statement[1]
+        /Block[1]/BlockStatement[1]/Statement/EmptyStatement
+       or ../../../../../../WhileStatement/Statement[1]
+        /Block[1]/BlockStatement[1]/Statement/EmptyStatement)
+ ]
+]]>
+                </value>
+            </property>
+        </properties>
+        <priority>3</priority>
+       <example>
+<![CDATA[public class MyClass {
+   public void doit()
+   {
+      // this is probably not what you meant to do
+      ;
+      // the extra semicolon here this is not necessary
+      System.out.println("look at the extra semicolon");;
+   }
+}]]>
+       </example>
+     </rule>
+
+    <rule name="BooleanInstantiation"
+       message="Avoid instantiating Boolean objects; you can usually invoke Boolean.TRUE instead."
+       class="net.sourceforge.pmd.rules.XPathRule">
+   <description>
+   Avoid instantiating Boolean objects, instead use Boolean.TRUE or Boolean.FALSE.
+   </description>
+      <properties>
+          <property name="xpath">
+              <value>
+<![CDATA[
+//PrimaryExpression
+[
+PrimaryPrefix/AllocationExpression[not (ArrayDimsAndInits) and (ClassOrInterfaceType/@Image='Boolean' or ClassOrInterfaceType/@Image='java.lang.Boolean')]
+or
+(
+PrimaryPrefix/Name[@Image='Boolean.valueOf']
+and
+PrimarySuffix/Arguments//BooleanLiteral
+)
+]
+]]>
+              </value>
+          </property>
+      </properties>
+      <priority>2</priority>
+   <example>
+   <![CDATA[
+public class Foo {
+ private Boolean bar = new Boolean("true"); // just do a Boolean bar = Boolean.TRUE;
+}
+   ]]>
+   </example>
+   </rule>
+
+    <rule name="UnnecessaryFinalModifier"
+          message="Unnecessary final modifier in final class"
+          class="net.sourceforge.pmd.rules.XPathRule">
+      <description>
+  When a class has the final modifier, all the methods are marked finally.
+      </description>
+      <properties>
+          <property name="xpath">
+              <value>
+    <![CDATA[
+//ClassOrInterfaceDeclaration[@Final='true' and @Interface='false']
+/ClassOrInterfaceBody/ClassOrInterfaceBodyDeclaration/MethodDeclaration[@Final='true']
+    ]]>
+              </value>
+          </property>
+      </properties>
+        <priority>3</priority>
+
+      <example>
+<![CDATA[
+public final class Foo {
+
+    // This final modifier is not necessary, since the class is final
+    // and thus, all methods are final
+	private final void foo() {
+	}
+
+}
+
+]]>
+      </example>
+    </rule>
+
+    <rule name="CollapsibleIfStatements"
+          message="These nested if statements could be combined"
+          class="net.sourceforge.pmd.rules.XPathRule">
+      <description>
+      Sometimes two 'if' statements can be consolidated by separating their conditions with a boolean short-circuit operator.
+      </description>
+    <properties>
+        <property name="xpath">
+            <value>
+                <![CDATA[
+//IfStatement[@Else='false']/Statement
+ /IfStatement[@Else='false']
+ |
+//IfStatement[@Else='false']/Statement
+ /Block[count(BlockStatement)=1]/BlockStatement
+  /Statement/IfStatement[@Else='false']]]>
+            </value>
+        </property>
+    </properties>
+        <priority>3</priority>
+      <example>
+  <![CDATA[public class Foo {
+      void bar() {
+          if (x) {
+           if (y) {
+             // do stuff
+           }
+          }
+      }
+  }]]>
+      </example>
+    </rule>
+
+</ruleset>
diff --git a/pmd-eclipse-test-fragment/src/rulesets/extra2.xml b/pmd-eclipse-test-fragment/src/rulesets/extra2.xml
new file mode 100644
index 0000000000..4d47329e1c
--- /dev/null
+++ b/pmd-eclipse-test-fragment/src/rulesets/extra2.xml
@@ -0,0 +1,129 @@
+<?xml version="1.0"?>
+
+<ruleset name="Extra Rules 2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:noNamespaceSchemaLocation="../etc/ruleset_xml_schema.xml">
+  <description>
+The Braces Ruleset contains a collection of braces rules.
+  </description>
+
+   <rule name="IfStmtsMustUseBraces"
+         message="Avoid using if statements without curly braces"
+         class="net.sourceforge.pmd.rules.XPathRule">
+     <description>
+     Avoid using if statements without using curly braces
+     </description>
+       <properties>
+           <property name="xpath">
+               <value>
+                   <![CDATA[
+    //IfStatement[count(*) < 3][not(Statement/Block)]
+                   ]]>
+               </value>
+           </property>
+       </properties>
+       <priority>3</priority>
+
+     <example>
+ <![CDATA[
+ public class Foo {
+   public void bar() {
+     int x = 0;
+     if (foo) x++;
+   }
+ }
+ ]]>
+     </example>
+     </rule>
+
+    <rule name="WhileLoopsMustUseBraces"
+          message="Avoid using 'while' statements without curly braces"
+          class="net.sourceforge.pmd.rules.XPathRule">
+      <description>
+      Avoid using 'while' statements without using curly braces
+      </description>
+        <properties>
+            <property name="xpath">
+                <value>
+                    <![CDATA[
+    //WhileStatement[not(Statement/Block)]
+                    ]]>
+                </value>
+            </property>
+        </properties>
+        <priority>3</priority>
+
+      <example>
+  <![CDATA[
+    public void doSomething() {
+      while (true)
+          x++;
+    }
+  ]]>
+      </example>
+    </rule>
+
+      <rule name="IfElseStmtsMustUseBraces"
+           message="Avoid using 'if...else' statements without curly braces"
+           class="net.sourceforge.pmd.rules.XPathRule">
+       <description>
+       Avoid using if..else statements without using curly braces
+       </description>
+         <properties>
+             <property name="xpath">
+                 <value>
+<![CDATA[
+//Statement
+ [parent::IfStatement[@Else='true']]
+ [not(child::Block)]
+ [not(child::IfStatement)]
+ ]]>
+                 </value>
+             </property>
+         </properties>
+         <priority>3</priority>
+
+       <example>
+   <![CDATA[
+
+     public void doSomething() {
+       // this is OK
+       if (foo) x++;
+
+       // but this is not
+       if (foo)
+           x=x+1;
+       else
+           x=x-1;
+     }
+   ]]>
+       </example>
+     </rule>
+
+     <rule name="ForLoopsMustUseBraces"
+           message="Avoid using 'for' statements without curly braces"
+           class="net.sourceforge.pmd.rules.XPathRule">
+       <description>
+       Avoid using 'for' statements without using curly braces
+       </description>
+         <properties>
+             <property name="xpath">
+                 <value>
+                     <![CDATA[
+    //ForStatement[not(Statement/Block)]
+                     ]]>
+                 </value>
+             </property>
+         </properties>
+         <priority>3</priority>
+
+       <example>
+   <![CDATA[
+     public void foo() {
+       for (int i=0; i<42;i++)
+           foo();
+     }
+   ]]>
+       </example>
+     </rule>
+
+</ruleset>