diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/LiteralsFirstInComparisons.xml b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/LiteralsFirstInComparisons.xml index e0be963130..024ff927ab 100644 --- a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/LiteralsFirstInComparisons.xml +++ b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/LiteralsFirstInComparisons.xml @@ -1,93 +1,89 @@ + xmlns="http://pmd.sourceforge.net/rule-tests" + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" + xsi:schemaLocation="http://pmd.sourceforge.net/rule-tests http://pmd.sourceforge.net/rule-tests_1_0_0.xsd"> + - -ok, literal comes first in .equals comparison - + ok, literal comes first in .equals comparison 0 + ]]> + - -bad, literal comes last in .equals comparison - + bad, literal comes last in .equals comparison 1 + ]]> + - -ok, empty literal in .equals comparison - + ok, empty literal in .equals comparison 0 + ]]> - - -Test case from bug [1472195] - PositionLiteralsFirstInComparisons gives many .equals false positives - - 0 - - - - -Test case from bug [1472195] - PositionLiteralsFirstInComparisons gives many .equals false positives - - 0 - + Test case from bug [1472195] - PositionLiteralsFirstInComparisons gives many .equals false positives + 0 + + ]]> + + + Test case from bug [1472195] - PositionLiteralsFirstInComparisons gives many .equals false positives + 0 + + + #1256 PositionLiteralsFirstInComparisons .equals false positive with Characters 0 @@ -102,196 +98,181 @@ public class LiteralTest { - -ok, literal comes first in .equalsIgnoreCase comparison - + ok, literal comes first in .equalsIgnoreCase comparison 0 + ]]> - - -bad, literal comes last in .equalsIgnoreCase comparison - - 1 - - - - -ok, testing .equalsIgnoreCase false positive - - 0 - - - - -Test case from bug [1472195] - PositionLiteralsFirstInComparisons gives many .equalsIgnoreCase false positives - - 0 - - - - -Test case from bug [1472195] - PositionLiteralsFirstInComparisons gives many .equalsIgnoreCase false positives - - 0 - - - -ok, literal comes first in .compareTo comparison - - 0 - - - - -bad, literal comes last in .compareTo comparison - + bad, literal comes last in .equalsIgnoreCase comparison 1 0; - } + boolean bar(String x) { + return x.equalsIgnoreCase("2"); + } } - ]]> + ]]> + - -ok, testing for .compareTo false positive - + ok, testing .equalsIgnoreCase false positive 0 + ]]> + - -ok, literal comes first in .compareToIgnoreCase comparison - + Test case from bug [1472195] - PositionLiteralsFirstInComparisons gives many .equalsIgnoreCase false positives + 0 + + + + + Test case from bug [1472195] - PositionLiteralsFirstInComparisons gives many .equalsIgnoreCase false positives + 0 + + + + + ok, literal comes first in .compareTo comparison 0 + ]]> + - -bad, literal comes last in .compareToIgnoreCase comparison - + bad, literal comes last in .compareTo comparison 1 0; - } + boolean bar(String x) { + return x.compareTo("2") > 0; + } } - ]]> + ]]> + - -ok, testing ,compareToIgnoreCase false positive - + ok, testing for .compareTo false positive 0 + ]]> + - -ok, literal comes first in .contentEquals comparison - + ok, literal comes first in .compareToIgnoreCase comparison 0 + ]]> + - -bad, literal comes last in .contentEquals comparison - + bad, literal comes last in .compareToIgnoreCase comparison 1 0; + } } - ]]> + ]]> + - -ok, testing .contentEquals false positive - + ok, testing ,compareToIgnoreCase false positive 0 + ]]> + + + + ok, literal comes first in .contentEquals comparison + 0 + + + + + bad, literal comes last in .contentEquals comparison + 1 + + + + + ok, testing .contentEquals false positive + 0 +