diff --git a/pmd-eclipse-plugin/plugins/net.sourceforge.pmd.eclipse.plugin/src/net/sourceforge/pmd/eclipse/ui/preferences/br/RuleUtil.java b/pmd-eclipse-plugin/plugins/net.sourceforge.pmd.eclipse.plugin/src/net/sourceforge/pmd/eclipse/ui/preferences/br/RuleUtil.java index 6a866f3da7..d2862dffac 100755 --- a/pmd-eclipse-plugin/plugins/net.sourceforge.pmd.eclipse.plugin/src/net/sourceforge/pmd/eclipse/ui/preferences/br/RuleUtil.java +++ b/pmd-eclipse-plugin/plugins/net.sourceforge.pmd.eclipse.plugin/src/net/sourceforge/pmd/eclipse/ui/preferences/br/RuleUtil.java @@ -112,18 +112,18 @@ public class RuleUtil { } public static Set> uniqueItemsIn(Object item, RuleFieldAccessor getter) { - - Set> values = null; - + if (item instanceof Rule) { - values = new HashSet>(1); + Set> values = new HashSet>(1); values.add( getter.valueFor((Rule) item) ); + return values; } if (item instanceof RuleCollection) { - values = getter.uniqueValuesFor((RuleCollection)item); + return getter.uniqueValuesFor((RuleCollection)item); } - return values; + + return Collections.emptySet(); } /**