From 609750332a27a9f905c4dd65beef618c2f7e009e Mon Sep 17 00:00:00 2001
From: Jeff Hube <jeff2365@gmail.com>
Date: Tue, 14 May 2019 11:33:34 -0400
Subject: [PATCH] Deprecate VariableNamingConventionsRule

---
 .../apex/rule/codestyle/VariableNamingConventionsRule.java | 1 +
 pmd-apex/src/main/resources/category/apex/codestyle.xml    | 7 +++++++
 2 files changed, 8 insertions(+)

diff --git a/pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/codestyle/VariableNamingConventionsRule.java b/pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/codestyle/VariableNamingConventionsRule.java
index ff1cc6caa2..19ca2c92a8 100644
--- a/pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/codestyle/VariableNamingConventionsRule.java
+++ b/pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/codestyle/VariableNamingConventionsRule.java
@@ -21,6 +21,7 @@ import net.sourceforge.pmd.lang.apex.ast.ApexNode;
 import net.sourceforge.pmd.lang.apex.rule.AbstractApexRule;
 import net.sourceforge.pmd.properties.PropertyDescriptor;
 
+@Deprecated
 public class VariableNamingConventionsRule extends AbstractApexRule {
 
     private boolean checkMembers;
diff --git a/pmd-apex/src/main/resources/category/apex/codestyle.xml b/pmd-apex/src/main/resources/category/apex/codestyle.xml
index a73567c18b..06800f2403 100644
--- a/pmd-apex/src/main/resources/category/apex/codestyle.xml
+++ b/pmd-apex/src/main/resources/category/apex/codestyle.xml
@@ -305,6 +305,7 @@ public class Foo {
 
     <rule name="VariableNamingConventions"
           since="5.5.0"
+          deprecated="true"
           message="{0} variable {1} should begin with {2}"
           class="net.sourceforge.pmd.lang.apex.rule.codestyle.VariableNamingConventionsRule"
           externalInfoUrl="${pmd.website.baseurl}/pmd_rules_apex_codestyle.html#variablenamingconventions">
@@ -312,6 +313,12 @@ public class Foo {
 A variable naming conventions rule - customize this to your liking.  Currently, it
 checks for final variables that should be fully capitalized and non-final variables
 that should not include underscores.
+
+This rule is deprecated. The rule is replaced
+by the more general rules {% rule apex/codestyle/FieldNamingConventions %},
+{% rule apex/codestyle/FormalParameterNamingConventions %},
+{% rule apex/codestyle/LocalVariableNamingConventions %}, and
+{% rule apex/codestyle/PropertyNamingConventions %}.
         </description>
         <priority>1</priority>
         <example>