phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed MethodNamingConventionsRule (isOverriddenMethod)

Browse Source
This commit is contained in:
David Renz
2016-03-29 17:14:54 +02:00
parent 0b81c72f40
commit 62aaf95e11
1 changed files with 2 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/naming/MethodNamingConventionsRule.java
View File

@ -3,11 +3,10 @@
*/
package net.sourceforge.pmd.lang.apex.rule.naming;
import java.util.List;
import net.sourceforge.pmd.lang.apex.ast.ASTCompilation;
import net.sourceforge.pmd.lang.apex.ast.ASTMethod;
import net.sourceforge.pmd.lang.apex.rule.AbstractApexRule;
import static apex.jorje.semantic.symbol.type.ModifierTypeInfos.OVERRIDE;
public class MethodNamingConventionsRule extends AbstractApexRule {
@ -32,15 +31,6 @@ public class MethodNamingConventionsRule extends AbstractApexRule {
}
private boolean isOverriddenMethod(ASTMethod node) {
ASTClassOrInterfaceBodyDeclaration declaration = node
.getFirstParentOfType(ASTClassOrInterfaceBodyDeclaration.class);
List<ASTMarkerAnnotation> annotations = declaration.findDescendantsOfType(ASTMarkerAnnotation.class);
for (ASTMarkerAnnotation ann : annotations) {
ASTName name = ann.getFirstChildOfType(ASTName.class);
if (name != null && name.hasImageEqualTo("Override")) {
return true;
}
}
return false;
return node.getNode().getModifiers().has(OVERRIDE);
}
}