From 657b82766621735fce6e375e676f3a7f3a78f71b Mon Sep 17 00:00:00 2001
From: Tom Copeland <tomcopeland@users.sourceforge.net>
Date: Thu, 20 Feb 2003 19:33:07 +0000
Subject: [PATCH] Some updates thx to Andrew Glover

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@1456 51baf565-9d33-0410-a72c-fc3788e3496d
---
 pmd/xdocs/credits.xml         | 1 +
 pmd/xdocs/howtowritearule.xml | 9 +++++----
 pmd/xdocs/navigation.xml      | 4 ++--
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/pmd/xdocs/credits.xml b/pmd/xdocs/credits.xml
index c86621b341..8d0e539023 100644
--- a/pmd/xdocs/credits.xml
+++ b/pmd/xdocs/credits.xml
@@ -10,6 +10,7 @@
     <section name="Credits">
         <subsection name="Individuals">
         <ul>
+            <li>Andrew Glover - documentation tweaks</li>
             <li>Adam Nemeth - bug report on missing final attribute for local variable declarations</li>
             <li>Gunnlaugur Thor Briem - bug report on JavaCC parser's use of java.lang.Error</li>
             <li>Carl Gilbert - ConstructorCallsOverridableMethodRule, bug reports, feature requests, and documentation improvements</li>
diff --git a/pmd/xdocs/howtowritearule.xml b/pmd/xdocs/howtowritearule.xml
index a696409c49..abeff80832 100644
--- a/pmd/xdocs/howtowritearule.xml
+++ b/pmd/xdocs/howtowritearule.xml
@@ -116,11 +116,11 @@ WhileStatement
 
     <subsection name="Write a rule class">
     <p>
-    Create a new Java class that extends <code>net.sourceforge.pmd.AbstractRule</code>:
+    Create a new Java class that extends <code>net.sourceforge.pmd.AbstractRule</code> and implements <code>net.sourceforge.pmd.Rule</code>:
     </p>
     <source>
 <![CDATA[
-public class WhileLoopsMustUseBracesRule extends AbstractRule {
+public class WhileLoopsMustUseBracesRule extends AbstractRule implements Rule {
 }
 ]]>
     </source>
@@ -130,9 +130,10 @@ public class WhileLoopsMustUseBracesRule extends AbstractRule {
     </p>
     <source>
 <![CDATA[
-public class WhileLoopsMustUseBracesRule extends AbstractRule {
+public class WhileLoopsMustUseBracesRule extends AbstractRule implements Rule {
     public Object visit(ASTWhileStatement node, Object data) {
         System.out.println("hello world");
+        return data;
     }
 }
 ]]>
@@ -178,7 +179,7 @@ public class WhileLoopsMustUseBracesRule extends AbstractRule {
     </p>
     <source>
 <![CDATA[
-public class WhileLoopsMustUseBracesRule extends AbstractRule {
+public class WhileLoopsMustUseBracesRule extends AbstractRule implements Rule {
     public Object visit(ASTWhileStatement node, Object data) {
         SimpleNode firstStmt = (SimpleNode)node.jjtGetChild(1);
         if (!hasBlockAsFirstChild(firstStmt)) {
diff --git a/pmd/xdocs/navigation.xml b/pmd/xdocs/navigation.xml
index 0e4de68f8a..c41cf7b0b9 100644
--- a/pmd/xdocs/navigation.xml
+++ b/pmd/xdocs/navigation.xml
@@ -18,9 +18,9 @@
       <item name="Running PMD" href="/running.html" />
       <item name="Plugins" href="/integrations.html" />
       <item name="Using the Ant Task" href="/ant-task.html" />
-      <item name="How to write a PMD rule" href="/howtowritearule.html" />
+      <item name="How to write a rule" href="/howtowritearule.html" />
       <item name="How to make a rule set" href="/howtomakearuleset.html" />
-      <item name="How PMD works" href="/howitworks.html" />
+      <item name="How it works" href="/howitworks.html" />
       <item name="Finding copied and pasted code" href="/cpd.html" />
       <item name="Similar projects" href="/similar-projects.html" />
       <item name="Credits" href="/credits.html" />