From 709396d8f3162e20920ae8334b28f0d19a056c1d Mon Sep 17 00:00:00 2001
From: Andreas Dangel <andreas.dangel@pmd-code.org>
Date: Fri, 5 Apr 2024 15:45:29 +0200
Subject: [PATCH] [java] InvalidLogMessageFormat: Add test case for #253

---
 .../xml/InvalidLogMessageFormat.xml           | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/errorprone/xml/InvalidLogMessageFormat.xml b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/errorprone/xml/InvalidLogMessageFormat.xml
index 4fa5f4f177..a10a2c546d 100644
--- a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/errorprone/xml/InvalidLogMessageFormat.xml
+++ b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/errorprone/xml/InvalidLogMessageFormat.xml
@@ -1181,6 +1181,33 @@ public class Foo {
 		LOGGER.warn("Exception {}", IllegalStateException.class.getName(), exception());
 	}
 }
+]]></code>
+    </test-code>
+
+    <test-code>
+        <description>slf4j: [java] InvalidLogMessageFormat doesn't handle formats assembled via multi-stage concatenation #253</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class Slf4JMessageFormatConcatenation {
+    private static final Logger LOG = LoggerFactory.getLogger(Slf4JMessageFormatConcatenation.class);
+
+    public void run() {
+        String message = "Field: {}";
+        // some code
+        String error = message + ", error: {}";
+
+        LOG.error(error, "fieldValue", "errorMessage"); // two placeholders, two args
+
+        // string concat with 7 params
+        int a, b, c, d, e, f, g;
+        LOGGER.warn("blah blah a={}, b={}, c={}, " +
+                            "d={}, e={}, f={}, g={}",
+                    a, b, c, d, e, f, g);
+    }
+}
 ]]></code>
     </test-code>
 </test-data>