phoedos/pmd
1
1
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed ExcessiveParameterListRule

Browse Source
This commit is contained in:
David Renz
2016-04-01 17:21:44 +02:00
parent d22bfe7b70
commit 74b922af35
2 changed files with 23 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/codesize/ExcessiveParameterListRule.java
View File

@ -4,6 +4,7 @@
package net.sourceforge.pmd.lang.apex.rule.codesize;
import net.sourceforge.pmd.lang.apex.ast.ASTParameter;
import net.sourceforge.pmd.lang.apex.ast.ASTUserClass;
import net.sourceforge.pmd.lang.apex.rule.design.ExcessiveNodeCountRule;
import net.sourceforge.pmd.util.NumericConstants;
@ -14,7 +15,7 @@ import net.sourceforge.pmd.util.NumericConstants;
*/
public class ExcessiveParameterListRule extends ExcessiveNodeCountRule {
public ExcessiveParameterListRule() {
super(ASTParameter.class);
super(ASTUserClass.class);
setProperty(MINIMUM_DESCRIPTOR, 10d);
}

42
pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/codesize/xml/ExcessiveParameterList.xml
View File

@ -1,28 +1,28 @@
<?xml version="1.0" encoding="UTF-8"?>
<test-data>
<test-code>
<description><![CDATA[
short
]]></description>
<rule-property name="minimum">9</rule-property>
<expected-problems>0</expected-problems>
<code><![CDATA[
<test-code>
<description>short</description>
<rule-property name="minimum">9</rule-property>
<expected-problems>0</expected-problems>
<code><![CDATA[
public class Foo {
public void foo() {}
public void foo() {}
}
]]></code>
</test-code>
<test-code>
<description><![CDATA[
long
]]></description>
<rule-property name="minimum">9</rule-property>
<expected-problems>1</expected-problems>
<code><![CDATA[
]]></code>
</test-code>
<test-code>
<description>long</description>
<rule-property name="minimum">9</rule-property>
<expected-problems>1</expected-problems>
<code><![CDATA[
public class Foo {
public void foo(Integer p01, Integer p02, Integer p03, Integer p04, Integer p05, Integer p06, Integer p07, Integer p08, Integer p09, Integer p10 ) { }
public void bar(Integer p01, Integer p02, Integer p03, Integer p04, Integer p05 ) { }
public void foo(Integer p01, Integer p02, Integer p03, Integer p04, Integer p05, Integer p06, Integer p07, Integer p08, Integer p09, Integer p10 ) { }
public void bar(Integer p01, Integer p02, Integer p03, Integer p04, Integer p05 ) { }
}
]]></code>
</test-code>
]]></code>
</test-code>
</test-data>