diff --git a/docs/pages/release_notes.md b/docs/pages/release_notes.md index 8abb75f161..a0c5c59808 100644 --- a/docs/pages/release_notes.md +++ b/docs/pages/release_notes.md @@ -21,9 +21,15 @@ This is a {{ site.pmd.release_type }} release. ### Fixed Issues +* pmd-java + * [#2708](https://github.com/pmd/pmd/pull/2708): \[java] False positive FinalFieldCouldBeStatic when using lombok Builder.Default + + ### API Changes ### External Contributions +* [#2747](https://github.com/pmd/pmd/pull/2747): \[java] Don't trigger FinalFieldCouldBeStatic when field is annotated with lombok @Builder.Default - [Ollie Abbey](https://github.com/ollieabbey) + {% endtocmaker %} diff --git a/pmd-java/src/main/resources/category/java/design.xml b/pmd-java/src/main/resources/category/java/design.xml index 8c961b9cea..7968b6ec57 100644 --- a/pmd-java/src/main/resources/category/java/design.xml +++ b/pmd-java/src/main/resources/category/java/design.xml @@ -723,8 +723,11 @@ in each object at runtime. diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/design/xml/FinalFieldCouldBeStatic.xml b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/design/xml/FinalFieldCouldBeStatic.xml index ea8200e411..ebd108cc17 100644 --- a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/design/xml/FinalFieldCouldBeStatic.xml +++ b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/design/xml/FinalFieldCouldBeStatic.xml @@ -1,8 +1,8 @@ + xmlns="http://pmd.sourceforge.net/rule-tests" + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" + xsi:schemaLocation="http://pmd.sourceforge.net/rule-tests http://pmd.sourceforge.net/rule-tests_1_0_0.xsd"> simple failure case @@ -98,6 +98,57 @@ interface Test { + + + + #2708 - False positive with lombok @Builder.Default fields + 0 + + + + + #2708 - Should trigger with non-lombok @Builder.Default fields + 1 + + + + + Should trigger multiple times for fields declared on one line + 2 + diff --git a/pom.xml b/pom.xml index dbd15cb634..b7c5c0bd1a 100644 --- a/pom.xml +++ b/pom.xml @@ -415,12 +415,12 @@ net.sourceforge.pmd pmd-core - 6.26.0 + 6.27.0 net.sourceforge.pmd pmd-java - 6.26.0 + 6.27.0