From 7d7c2dc94a323e0b3fa5724b3fc62ca88117502e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Fournier?= Date: Thu, 26 Apr 2018 15:02:55 +0200 Subject: [PATCH] Add known issue disclaimer --- pmd-dist/src/main/scripts/run.sh | 2 +- .../sourceforge/pmd/util/fxdesigner/MainDesignerController.java | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/pmd-dist/src/main/scripts/run.sh b/pmd-dist/src/main/scripts/run.sh index 283d00de09..fa41cf748d 100755 --- a/pmd-dist/src/main/scripts/run.sh +++ b/pmd-dist/src/main/scripts/run.sh @@ -78,7 +78,7 @@ jre_specific_vm_options() { # java_ver is eg "18" for java 1.8, "90" for java 9.0 java_ver=$(java -version 2>&1 | sed -n ';s/.* version "\(.*\)\.\(.*\)\..*"/\1\2/p;') options="" - + if [ $java_ver -ge 90 ] && [ "${APPNAME}" = "designer" ] then # open internal module of javafx to reflection options="--add-opens javafx.controls/javafx.scene.control.skin=ALL-UNNAMED" diff --git a/pmd-ui/src/main/java/net/sourceforge/pmd/util/fxdesigner/MainDesignerController.java b/pmd-ui/src/main/java/net/sourceforge/pmd/util/fxdesigner/MainDesignerController.java index 517c745730..d2bdd51a85 100644 --- a/pmd-ui/src/main/java/net/sourceforge/pmd/util/fxdesigner/MainDesignerController.java +++ b/pmd-ui/src/main/java/net/sourceforge/pmd/util/fxdesigner/MainDesignerController.java @@ -237,6 +237,8 @@ public class MainDesignerController implements Initializable, SettingsOwner { */ public void onNodeItemSelected(Node selectedValue) { nodeInfoPanelController.displayInfo(selectedValue); + // The following line causes problems, since it wipes out the name occurrence highlighting, + // but it's already fixed in a PR to come soon sourceEditorController.clearNodeHighlight(); sourceEditorController.highlightNodePrimary(selectedValue); sourceEditorController.focusNodeInTreeView(selectedValue);