From 8057a5c0df1051ee6b00440650621765560db179 Mon Sep 17 00:00:00 2001
From: Romain PELISSE <belaran@gmail.com>
Date: Sat, 9 May 2015 00:44:40 +0200
Subject: [PATCH] Add a new rule 'InvalidDependencyType' to pom rulesets

---
 .../src/main/resources/rulesets/pom/basic.xml | 44 +++++++++++++++-
 .../pom/rule/basic/xml/InvalidDepencyType.xml | 51 +++++++++++++++++++
 2 files changed, 94 insertions(+), 1 deletion(-)
 create mode 100644 pmd-xml/src/test/resources/net/sourceforge/pmd/lang/pom/rule/basic/xml/InvalidDepencyType.xml

diff --git a/pmd-xml/src/main/resources/rulesets/pom/basic.xml b/pmd-xml/src/main/resources/rulesets/pom/basic.xml
index 5b4295f22a..d08cdbff6c 100644
--- a/pmd-xml/src/main/resources/rulesets/pom/basic.xml
+++ b/pmd-xml/src/main/resources/rulesets/pom/basic.xml
@@ -42,4 +42,46 @@ ${project.version} in a BOM or parent POM.
  ]]>
      </example>
      </rule>
-</ruleset>
+
+  <rule name="InvalidDependencyTypes"
+        language="xml"
+        since="5.4"
+        message="By default, Maven only recognized the following types: $validTypes."
+        class="net.sourceforge.pmd.lang.rule.XPathRule"
+        externalInfoUrl="${pmd.website.baseurl}/rules/pom/basic.html#InvalidDependencyTypes">
+     <description><![CDATA[
+While Maven will not failed if you use an invalid type for a dependency in the dependency management section, it will not also uses the dependency. ]]>
+     </description>
+     <priority>3</priority>
+     <properties>
+         <property name="xpath">
+             <value>
+<![CDATA[
+//dependencyManagement/dependency/type/text[not(contains('pom, jar, maven-plugin, ejb, war, ear, rar, par',@Image))]
+]]>
+             </value>
+         </property>
+         <!-- FIXME: property injection seems to be failing with XML.... -->
+         <!-- property name="validTypes" value="pom, jar, maven-plugin, ejb, war, ear, rar, par" description="Set of valid types."-->
+     </properties>
+     <example>
+ <![CDATA[
+<project...>
+  ...
+  <dependencyManagement>
+      ...
+    <dependency>
+      <groupId>org.jboss.arquillian</groupId>
+      <artifactId>arquillian-bom</artifactId>
+      <version>${arquillian.version}</version>
+      <type>bom</type> <!-- not a valid type ! 'pom' is ! -->
+      <scope>import</scope>
+    </dependency>
+    ...
+  </dependencyManagement>
+</project>
+ ]]>
+     </example>
+     </rule>
+
+ </ruleset>
diff --git a/pmd-xml/src/test/resources/net/sourceforge/pmd/lang/pom/rule/basic/xml/InvalidDepencyType.xml b/pmd-xml/src/test/resources/net/sourceforge/pmd/lang/pom/rule/basic/xml/InvalidDepencyType.xml
new file mode 100644
index 0000000000..a0f93c8a7e
--- /dev/null
+++ b/pmd-xml/src/test/resources/net/sourceforge/pmd/lang/pom/rule/basic/xml/InvalidDepencyType.xml
@@ -0,0 +1,51 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<test-data>
+    <test-code>
+        <description>Simple POM file - no violation</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+    <groupId>net.sourceforge.pmd</groupId>
+    <artifactId>xml-pom</artifactId>
+    <version>1.0.0-SNAPSHOT</version>
+
+  <dependencyManagement>
+    <dependency>
+      <groupId>org.jboss.arquillian</groupId>
+      <artifactId>arquillian-bom</artifactId>
+      <version>${arquillian.version}</version>
+      <type>pom</type>
+      <scope>import</scope>
+    </dependency>
+  </dependencyManagement>
+
+</project>
+     ]]></code>
+        <source-type>xml</source-type>
+    </test-code>
+    <test-code>
+        <description>Simple POM file with violation</description>
+        <expected-problems>1</expected-problems>
+        <code><![CDATA[
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+    <groupId>net.sourceforge.pmd</groupId>
+    <artifactId>xml-pom</artifactId>
+    <version>1.0.0-SNAPSHOT</version>
+
+  <dependencyManagement>
+    <dependency>
+      <groupId>org.jboss.arquillian</groupId>
+      <artifactId>arquillian-bom</artifactId>
+      <version>${arquillian.version}</version>
+      <type>bom</type>
+      <scope>import</scope>
+    </dependency>
+  </dependencyManagement>
+
+</project>
+     ]]></code>
+        <source-type>xml</source-type>
+    </test-code>
+</test-data>