diff --git a/pmd-java/src/main/resources/rulesets/java/controversial.xml b/pmd-java/src/main/resources/rulesets/java/controversial.xml index f964cb5fb6..02e340615c 100644 --- a/pmd-java/src/main/resources/rulesets/java/controversial.xml +++ b/pmd-java/src/main/resources/rulesets/java/controversial.xml @@ -770,7 +770,7 @@ public void checkRequests() { When you write a public method, you should be thinking in terms of an API. If your method is public, it means other class will use it, therefore, you want (or need) to offer a comprehensive and evolutive API. If you pass a lot of information -as a simple series of Strings, you may think of using an Object to represent all those information. You'll get a simplier +as a simple series of Strings, you may think of using an Object to represent all those information. You'll get a simpler API (such as doWork(Workload workload), rather than a tedious series of Strings) and more importantly, if you need at some point to pass extra data, you'll be able to do so by simply modifying or extending Workload without any modification to your API. diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/basic/xml/BrokenNullCheck.xml b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/basic/xml/BrokenNullCheck.xml index 708a751a91..ed5b2ea8b7 100644 --- a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/basic/xml/BrokenNullCheck.xml +++ b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/basic/xml/BrokenNullCheck.xml @@ -155,7 +155,7 @@ public class Foo { 0 3 - bug #1131 CloseResource should complain if code betwen declaration of resource and try: Code betwen declaration and try, should fail + bug #1131 CloseResource should complain if code between declaration of resource and try: Code between declaration and try, should fail Connection 1 - bug #1131 CloseResource should complain if code betwen declaration of resource and try: Creation inside try, ok + bug #1131 CloseResource should complain if code between declaration of resource and try: Creation inside try, ok Connection 0 - bug #1131 CloseResource should complain if code betwen declaration of resource and try: No sentences between creation and try, ok + bug #1131 CloseResource should complain if code between declaration of resource and try: No sentences between creation and try, ok Connection 0 - #1259 CloseResource rule ignores conditionnals within finally blocks + #1259 CloseResource rule ignores conditionals within finally blocks 1 1 2 1 0 1 1