From 9810bfc3cc94295d9091d9324a169f05641f1dfe Mon Sep 17 00:00:00 2001
From: Andreas Dangel <andreas.dangel@pmd-code.org>
Date: Fri, 6 Sep 2024 18:42:03 +0200
Subject: [PATCH] [apex] Verify CognitiveComplexity for triggers

---
 .../rule/design/xml/CognitiveComplexity.xml   | 36 +++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/design/xml/CognitiveComplexity.xml b/pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/design/xml/CognitiveComplexity.xml
index 931578da46..034ca90956 100644
--- a/pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/design/xml/CognitiveComplexity.xml
+++ b/pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/design/xml/CognitiveComplexity.xml
@@ -222,4 +222,40 @@ public class Foo {
 }            ]]>
         </code>
     </test-code>
+
+    <test-code>
+        <description>Cognitive Complexity within triggers (#5138)</description>
+        <rule-property name="methodReportLevel">15</rule-property>
+        <expected-problems>1</expected-problems>
+        <expected-linenumbers>2</expected-linenumbers>
+        <expected-messages>
+            <message>The trigger 'AccountTrigger' has a cognitive complexity of 18, current threshold is 15</message>
+        </expected-messages>
+        <code><![CDATA[
+// https://github.com/SalesforceLabs/Partner-Onboarding/blob/main/Partner%20Onboarding/triggers/AccountTrigger.trigger
+trigger AccountTrigger on Account (after insert, after update) {
+
+    public List<Account> updatedAccounts = Trigger.new;
+    if(trigger.isAfter){
+        Map<Id,Account> mapOfOldValues = trigger.oldMap;
+        Map<Id,Id> accountWithOnboardingTemplateIDs = new Map<Id,Id>();
+        for(Account updated_Account : updatedAccounts) {
+            if(updated_Account.Onboarding_Plan__c != null)
+            {
+                if(mapOfOldValues == null){
+                    accountWithOnboardingTemplateIDs.put(updated_Account.Id, updated_Account.Onboarding_Plan__c);
+                } else {
+                    if(updated_Account.Onboarding_Plan__c != mapOfOldValues.get(updated_Account.Id).Onboarding_Plan__c)
+                        accountWithOnboardingTemplateIDs.put(updated_Account.Id, updated_Account.Onboarding_Plan__c);
+                }
+            }
+        } //End For
+
+        if(accountWithOnboardingTemplateIDs.size() > 0){
+            OnboardingPlanService.updateContactsWithOndbPlan(accountWithOnboardingTemplateIDs);
+        }
+    }
+}
+]]></code>
+    </test-code>
 </test-data>