From fda753813b2b5a5a53bc2f056c5a2a6c82552023 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juan=20Mart=C3=ADn=20Sotuyo=20Dodero?= <jmsotuyo@monits.com>
Date: Wed, 8 Jun 2016 19:59:58 -0300
Subject: [PATCH] Don't report bad method names on @Override

---
 .../src/main/resources/rulesets/java/naming.xml    |  1 +
 .../java/rule/naming/xml/BooleanGetMethodName.xml  | 14 ++++++++++++++
 2 files changed, 15 insertions(+)

diff --git a/pmd-java/src/main/resources/rulesets/java/naming.xml b/pmd-java/src/main/resources/rulesets/java/naming.xml
index 0cf323ebcb..f0c09c6a80 100644
--- a/pmd-java/src/main/resources/rulesets/java/naming.xml
+++ b/pmd-java/src/main/resources/rulesets/java/naming.xml
@@ -509,6 +509,7 @@ MethodDeclarator[count(FormalParameters/FormalParameter) = 0 or $checkParameteri
                 [starts-with(@Image, 'get')]
 and
 ResultType/Type/PrimitiveType[@Image = 'boolean']
+and not(../Annotation//Name[@Image = 'Override'])
 ]
 ]]>
                 </value>
diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/naming/xml/BooleanGetMethodName.xml b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/naming/xml/BooleanGetMethodName.xml
index c3f7e47b05..a342649356 100644
--- a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/naming/xml/BooleanGetMethodName.xml
+++ b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/naming/xml/BooleanGetMethodName.xml
@@ -35,6 +35,20 @@ public class Foo {
     </test-code>
     <test-code>
         <description><![CDATA[
+Should not match on methods annotated with @Override
+     ]]></description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+public class Foo implements Toggleable {
+    @Override
+    public boolean getEnabled() {
+        return true;
+    }
+}
+     ]]></code>
+    </test-code>
+    <test-code>
+        <description><![CDATA[
 Should match on multiple parameters when checkParameterizedMethods = true
      ]]></description>
         <expected-problems>1</expected-problems>