Merge branch 'bug-1443' into pmd/5.4.x

2015-11-16 21:39:16 +01:00
parent 0181f14347 90b1f65ea2
commit adf3e231af
3 changed files with 13 additions and 1 deletions
@@ -100,7 +100,7 @@ public class RedundantFieldInitializerRule extends AbstractJavaRule {
                                    value = (int) literal.getImage().charAt(1);
                                }

-                                if (value.longValue() == 0) {
+                                if (value.doubleValue() == 0) {
                                    addViolation(data, variableDeclarator);
                                }
                            }
@@ -1299,6 +1299,16 @@ public class Bar {
        <code><![CDATA[
 public class SomeClass {
    private long someNumber = 0x100000000000L;
+}
+        ]]></code>
+    </test-code>
+
+    <test-code>
+        <description>#1443 RedundantFieldInitializer: False positive for small floats</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+public class SomeClass {
+    private float someNumber = 0.1f;
 }
        ]]></code>
    </test-code>
@@ -24,6 +24,8 @@
        annotated with @VisibleForTesting
 *   java-finalizers/AvoidCallingFinalize
    *   [#1440](https://sourceforge.net/p/pmd/bugs/1440/): NPE in AvoidCallingFinalize
+*   java-optimizations/RedundantFieldInitializer
+    *   [#1443](https://sourceforge.net/p/pmd/bugs/1443/): RedundantFieldInitializer: False positive for small floats
 *   java-unusedcode/UnusedPrivateField
    *   [#1428](https://sourceforge.net/p/pmd/bugs/1428/): False positive in UnusedPrivateField when local variable
        hides member variable