diff --git a/docs/pages/release_notes.md b/docs/pages/release_notes.md index b8f8783555..1e215b2cd9 100644 --- a/docs/pages/release_notes.md +++ b/docs/pages/release_notes.md @@ -16,9 +16,14 @@ This is a {{ site.pmd.release_type }} release. ### Fixed Issues +* java-codestyle + * [#1547](https://github.com/pmd/pmd/issues/1547): \[java] AtLeastOneConstructorRule: false-positive with lombok.AllArgsConstructor + ### API Changes ### External Contributions +* [#1623](https://github.com/pmd/pmd/pull/1623): \[java] Fix lombok.AllArgsConstructor support - [Bobby Wertman](https://github.com/CasualSuperman) + {% endtocmaker %} diff --git a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/codestyle/AtLeastOneConstructorRule.java b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/codestyle/AtLeastOneConstructorRule.java index 2983c4eaad..ee06ee9951 100644 --- a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/codestyle/AtLeastOneConstructorRule.java +++ b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/codestyle/AtLeastOneConstructorRule.java @@ -33,7 +33,7 @@ public class AtLeastOneConstructorRule extends AbstractIgnoredAnnotationRule { "lombok.Builder", "lombok.NoArgsConstructor", "lombok.RequiredArgsConstructor", - "lombok.AllArgsConstructorAtLeastOneConstructor"); + "lombok.AllArgsConstructor"); } @Override diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/AtLeastOneConstructor.xml b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/AtLeastOneConstructor.xml index fe3fab3c72..ea0e7b2a4c 100644 --- a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/AtLeastOneConstructor.xml +++ b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/AtLeastOneConstructor.xml @@ -117,13 +117,57 @@ public class TestAtLeastOneConstructor { ]]> - Ignore classes with lombok-generated constructors + Ignore classes with lombok-generated constructors (Value) 0 + + + Ignore classes with lombok-generated constructors (Required) + 0 + + + + Ignore classes with lombok-generated constructors (No) + 0 + + + + Ignore classes with lombok-generated constructors (All) + 0 + + + + Ignore classes with lombok-generated constructors (Builder) + 0 +