From ea022f0e68f629ad48e3b9747aa6be56f0e9d35c Mon Sep 17 00:00:00 2001
From: Bobby Wertman <robert.wertman@gmail.com>
Date: Sun, 27 Jan 2019 10:55:45 -0500
Subject: [PATCH 1/2] [java] Fix lombok.AllArgsConstructor support

---
 .../codestyle/AtLeastOneConstructorRule.java  |  2 +-
 .../codestyle/xml/AtLeastOneConstructor.xml   | 46 ++++++++++++++++++-
 2 files changed, 46 insertions(+), 2 deletions(-)

diff --git a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/codestyle/AtLeastOneConstructorRule.java b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/codestyle/AtLeastOneConstructorRule.java
index 2983c4eaad..ee06ee9951 100644
--- a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/codestyle/AtLeastOneConstructorRule.java
+++ b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/codestyle/AtLeastOneConstructorRule.java
@@ -33,7 +33,7 @@ public class AtLeastOneConstructorRule extends AbstractIgnoredAnnotationRule {
                 "lombok.Builder",
                 "lombok.NoArgsConstructor",
                 "lombok.RequiredArgsConstructor",
-                "lombok.AllArgsConstructorAtLeastOneConstructor");
+                "lombok.AllArgsConstructor");
     }
 
     @Override
diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/AtLeastOneConstructor.xml b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/AtLeastOneConstructor.xml
index fe3fab3c72..ea0e7b2a4c 100644
--- a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/AtLeastOneConstructor.xml
+++ b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/AtLeastOneConstructor.xml
@@ -117,13 +117,57 @@ public class TestAtLeastOneConstructor {
         ]]></code>
     </test-code>
     <test-code>
-        <description>Ignore classes with lombok-generated constructors</description>
+        <description>Ignore classes with lombok-generated constructors (Value)</description>
         <expected-problems>0</expected-problems>
         <code><![CDATA[
 import lombok.Value;
 
 @Value
 public class TestAtLeastOneConstructor {
+}
+        ]]></code>
+    </test-code>
+    <test-code>
+        <description>Ignore classes with lombok-generated constructors (Required)</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+import lombok.RequiredArgsConstructor;
+
+@RequiredArgsConstructor
+public class TestAtLeastOneConstructor {
+}
+        ]]></code>
+    </test-code>
+    <test-code>
+        <description>Ignore classes with lombok-generated constructors (No)</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+import lombok.NoArgsConstructor;
+
+@NoArgsConstructor
+public class TestAtLeastOneConstructor {
+}
+        ]]></code>
+    </test-code>
+    <test-code>
+        <description>Ignore classes with lombok-generated constructors (All)</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+import lombok.AllArgsConstructor;
+
+@AllArgsConstructor
+public class TestAtLeastOneConstructor {
+}
+        ]]></code>
+    </test-code>
+    <test-code>
+        <description>Ignore classes with lombok-generated constructors (Builder)</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+import lombok.Builder;
+
+@Builder
+public class TestAtLeastOneConstructor {
 }
         ]]></code>
     </test-code>

From c76c9734e0ef8fd8c8158dd23e9d0c280fd87b50 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juan=20Mart=C3=ADn=20Sotuyo=20Dodero?=
 <juansotuyo@gmail.com>
Date: Mon, 28 Jan 2019 23:46:03 -0300
Subject: [PATCH 2/2] Update changelog, refs #1623

---
 docs/pages/release_notes.md | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/docs/pages/release_notes.md b/docs/pages/release_notes.md
index b8f8783555..1e215b2cd9 100644
--- a/docs/pages/release_notes.md
+++ b/docs/pages/release_notes.md
@@ -16,9 +16,14 @@ This is a {{ site.pmd.release_type }} release.
 
 ### Fixed Issues
 
+*   java-codestyle
+    *   [#1547](https://github.com/pmd/pmd/issues/1547): \[java] AtLeastOneConstructorRule: false-positive with lombok.AllArgsConstructor
+
 ### API Changes
 
 ### External Contributions
 
+*   [#1623](https://github.com/pmd/pmd/pull/1623): \[java] Fix lombok.AllArgsConstructor support - [Bobby Wertman](https://github.com/CasualSuperman)
+
 {% endtocmaker %}