From b33075a280433eff1ab430bff807fd1af33a6643 Mon Sep 17 00:00:00 2001 From: Andreas Dangel Date: Sat, 10 Aug 2013 15:02:01 +0200 Subject: [PATCH] pmd-eclipse: fix #1112 Eclipse log file will not be filled --- pmd-eclipse-plugin/ReleaseNotes.md | 2 ++ .../pmd/eclipse/runtime/preferences/IPreferences.java | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/pmd-eclipse-plugin/ReleaseNotes.md b/pmd-eclipse-plugin/ReleaseNotes.md index dcb217624b..4badb0c97d 100644 --- a/pmd-eclipse-plugin/ReleaseNotes.md +++ b/pmd-eclipse-plugin/ReleaseNotes.md @@ -10,6 +10,7 @@ Eclipse Update Site: http://sourceforge.net/projects/pmd/files/pmd-eclipse/updat * Fixed Violations are reported multiple times ([bug #1071]) * Fixed SWTError: No more handles on Violation Outline View ([bug #1096]) * Fixed Selecting non-duplicates during import doesn't work. ([bug #1110]) +* Fixed Eclipse log file will not be filled ([bug #1112]) * Fixed PMD Eclipse plugin doesn't analyze project if it has non-existing source folders ([bug #1116]) * Fixed An internal error occurred during: "RenderReport" ([bug #1117]) @@ -17,6 +18,7 @@ Eclipse Update Site: http://sourceforge.net/projects/pmd/files/pmd-eclipse/updat [bug #1071]: https://sourceforge.net/p/pmd/bugs/1071/ [bug #1096]: https://sourceforge.net/p/pmd/bugs/1096/ [bug #1110]: https://sourceforge.net/p/pmd/bugs/1110/ +[bug #1112]: https://sourceforge.net/p/pmd/bugs/1112/ [bug #1116]: https://sourceforge.net/p/pmd/bugs/1116/ [bug #1117]: https://sourceforge.net/p/pmd/bugs/1117/ diff --git a/pmd-eclipse-plugin/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/preferences/IPreferences.java b/pmd-eclipse-plugin/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/preferences/IPreferences.java index 71d3813b22..416f167a16 100644 --- a/pmd-eclipse-plugin/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/preferences/IPreferences.java +++ b/pmd-eclipse-plugin/net.sourceforge.pmd.eclipse.plugin/src/main/java/net/sourceforge/pmd/eclipse/runtime/preferences/IPreferences.java @@ -62,7 +62,7 @@ public interface IPreferences { String REVIEW_ADDITIONAL_COMMENT_DEFAULT = "by {0} on {1}"; boolean REVIEW_PMD_STYLE_ENABLED_DEFAULT = true; int MIN_TILE_SIZE_DEFAULT = 25; - String LOG_FILENAME_DEFAULT = "pmd-eclipse.log"; + String LOG_FILENAME_DEFAULT = System.getProperty("user.home") + "/pmd-eclipse.log"; Level LOG_LEVEL = Level.WARN; // default active rules - these are the rules from java-basic,java-imports,java-unusedcode String ACTIVE_RULES = "ExtendsObject,AvoidMultipleUnaryOperators,DoubleCheckedLocking,DuplicateImports,ReturnFromFinallyBlock,UnconditionalIfStatement,BooleanInstantiation,UnusedLocalVariable,AvoidThreadGroup,AvoidDecimalLiteralsInBigDecimalConstructor,DontUseFloatTypeForLoopIndices,MisplacedNullCheck,AvoidUsingHardCodedIP,UnnecessaryFullyQualifiedName,UnusedPrivateMethod,CheckResultSet,CollapsibleIfStatements,ForLoopShouldBeWhileLoop,DontImportJavaLang,JumbledIncrementer,OverrideBothEqualsAndHashcode,CheckSkipResult,DontCallThreadRun,TooManyStaticImports,AvoidUsingOctalValues,AvoidBranchingStatementAsLastInLoop,ImportFromSamePackage,ClassCastExceptionWithToArray,BrokenNullCheck,UnusedImports,UnusedModifier,UnusedPrivateField,UnusedFormalParameter,BigIntegerInstantiation";