From b2dc358abac1e6d0c68c8c07f278a8197b9f3eb2 Mon Sep 17 00:00:00 2001 From: Harsh Kukreja Date: Mon, 27 Apr 2020 09:09:07 +0530 Subject: [PATCH 1/2] Operator Wrap check --- .../errorprone/CloneMethodMustImplementCloneableRule.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/errorprone/CloneMethodMustImplementCloneableRule.java b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/errorprone/CloneMethodMustImplementCloneableRule.java index 0566a1ee45..495e9bf31c 100644 --- a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/errorprone/CloneMethodMustImplementCloneableRule.java +++ b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/errorprone/CloneMethodMustImplementCloneableRule.java @@ -91,8 +91,8 @@ public class CloneMethodMustImplementCloneableRule extends AbstractJavaRule { // Is the clone method just throwing CloneNotSupportedException? final ASTClassOrInterfaceDeclaration classOrInterface = node.getFirstParentOfType(ASTClassOrInterfaceDeclaration.class); - if (classOrInterface != null && //Don't analyze enums, which cannot subclass clone() - (node.isFinal() || classOrInterface.isFinal())) { + if (classOrInterface != null //Don't analyze enums, which cannot subclass clone() + && (node.isFinal() || classOrInterface.isFinal())) { if (node.findDescendantsOfType(ASTBlock.class).size() == 1) { final List blocks = node.findDescendantsOfType(ASTBlockStatement.class); if (blocks.size() == 1) { From 9416a8fa65a8a00967570a67492824a8dac2fa45 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Fournier?= Date: Mon, 27 Apr 2020 21:25:23 +0200 Subject: [PATCH 2/2] Update release notes, refs #2448 --- docs/pages/release_notes.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/pages/release_notes.md b/docs/pages/release_notes.md index b8f8783555..f6837bea9b 100644 --- a/docs/pages/release_notes.md +++ b/docs/pages/release_notes.md @@ -20,5 +20,8 @@ This is a {{ site.pmd.release_type }} release. ### External Contributions +* [#2448](https://github.com/pmd/pmd/pull/2448): \[java] Operator Wrap check - [Harsh Kukreja](https://github.com/harsh-kukreja) + + {% endtocmaker %}