diff --git a/pmd-java/src/main/resources/rulesets/java/unnecessary.xml b/pmd-java/src/main/resources/rulesets/java/unnecessary.xml index 97d5e1ff09..2c6d44fabb 100644 --- a/pmd-java/src/main/resources/rulesets/java/unnecessary.xml +++ b/pmd-java/src/main/resources/rulesets/java/unnecessary.xml @@ -275,5 +275,55 @@ public class Foo { ]]> - + + + Look for qualified this usages in the same class. + 3 + + + + + + + + + + + + \ No newline at end of file diff --git a/pmd-java/src/test/java/net/sourceforge/pmd/lang/java/rule/unnecessary/UnnecessaryRulesTest.java b/pmd-java/src/test/java/net/sourceforge/pmd/lang/java/rule/unnecessary/UnnecessaryRulesTest.java index 1b33b2dc09..1bd462dcf7 100644 --- a/pmd-java/src/test/java/net/sourceforge/pmd/lang/java/rule/unnecessary/UnnecessaryRulesTest.java +++ b/pmd-java/src/test/java/net/sourceforge/pmd/lang/java/rule/unnecessary/UnnecessaryRulesTest.java @@ -21,5 +21,6 @@ public class UnnecessaryRulesTest extends SimpleAggregatorTst { addRule(RULESET, "UselessOverridingMethod"); addRule(RULESET, "UselessOperationOnImmutable"); addRule(RULESET, "UselessParentheses"); + addRule(RULESET, "UselessQualifiedThis"); } } diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/unnecessary/xml/UselessQualifiedThis.xml b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/unnecessary/xml/UselessQualifiedThis.xml new file mode 100644 index 0000000000..3b426d7f15 --- /dev/null +++ b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/unnecessary/xml/UselessQualifiedThis.xml @@ -0,0 +1,133 @@ + + + + + + + 1 + + + + + + + + + + 1 + + + + + + + + + + 0 + + + + + + + + + + 0 + + + + + + + + + + 1 + + + + + + + + + + 3 + + + + + + \ No newline at end of file