From bb36eace93c007d24ffd264622898852091e7596 Mon Sep 17 00:00:00 2001
From: Tom Copeland <tomcopeland@users.sourceforge.net>
Date: Wed, 4 Sep 2002 14:59:34 +0000
Subject: [PATCH] moved some rules into a new braces ruleset

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@833 51baf565-9d33-0410-a72c-fc3788e3496d
---
 pmd/rulesets/basic.xml           | 58 --------------------------
 pmd/rulesets/braces.xml          | 70 ++++++++++++++++++++++++++++++++
 pmd/rulesets/rulesets.properties |  2 +-
 3 files changed, 71 insertions(+), 59 deletions(-)
 create mode 100644 pmd/rulesets/braces.xml

diff --git a/pmd/rulesets/basic.xml b/pmd/rulesets/basic.xml
index 0112b94d85..020dbb66d0 100644
--- a/pmd/rulesets/basic.xml
+++ b/pmd/rulesets/basic.xml
@@ -62,30 +62,6 @@ while (a == b) {
      </example>
   </rule>
 
-  <rule name="IfElseStmtsMustUseBracesRule"
-        message="Avoid using 'if...else' statements without curly braces"
-        class="net.sourceforge.pmd.rules.IfElseStmtsMustUseBracesRule">
-    <description>
-    Avoid using if..else statements without using curly braces
-    </description>
-
-    <example>
-<![CDATA[
-
-  public void doSomething() {
-    // this is OK
-    if (foo) x++;
-
-    // but this is not
-    if (foo)
-        x=x+1;
-    else
-        x=x-1;
-  }
-]]>
-    </example>
-  </rule>
-
   <rule name="UnnecessaryConversionTemporaryRule"
         message="Avoid unnecessary temporaries when converting primitives to Strings"
         class="net.sourceforge.pmd.rules.UnnecessaryConversionTemporaryRule">
@@ -181,40 +157,6 @@ public void bar() {
     </example>
   </rule>
 
-  <rule name="WhileLoopsMustUseBracesRule"
-        message="Avoid using 'while' statements without curly braces"
-        class="net.sourceforge.pmd.rules.WhileLoopsMustUseBracesRule">
-    <description>
-    Avoid using 'while' statements without using curly braces
-    </description>
-
-    <example>
-<![CDATA[
-  public void doSomething() {
-    while (true)
-        x++;
-  }
-]]>
-    </example>
-  </rule>
-
-  <rule name="ForLoopsMustUseBracesRule"
-        message="Avoid using 'for' statements without curly braces"
-        class="net.sourceforge.pmd.rules.ForLoopsMustUseBracesRule">
-    <description>
-    Avoid using 'for' statements without using curly braces
-    </description>
-
-    <example>
-<![CDATA[
-  public void foo() {
-    for (int i=0; i<42;i++)
-        foo();
-  }
-]]>
-    </example>
-  </rule>
-
   </ruleset>
 
 
diff --git a/pmd/rulesets/braces.xml b/pmd/rulesets/braces.xml
new file mode 100644
index 0000000000..367f3334b9
--- /dev/null
+++ b/pmd/rulesets/braces.xml
@@ -0,0 +1,70 @@
+<?xml version="1.0"?>
+
+<ruleset name="Braces Rules">
+  <description>
+The Braces Ruleset contains a collection of braces rules.
+  </description>
+
+
+  <rule name="IfElseStmtsMustUseBracesRule"
+        message="Avoid using 'if...else' statements without curly braces"
+        class="net.sourceforge.pmd.rules.IfElseStmtsMustUseBracesRule">
+    <description>
+    Avoid using if..else statements without using curly braces
+    </description>
+
+    <example>
+<![CDATA[
+
+  public void doSomething() {
+    // this is OK
+    if (foo) x++;
+
+    // but this is not
+    if (foo)
+        x=x+1;
+    else
+        x=x-1;
+  }
+]]>
+    </example>
+  </rule>
+
+  <rule name="WhileLoopsMustUseBracesRule"
+        message="Avoid using 'while' statements without curly braces"
+        class="net.sourceforge.pmd.rules.WhileLoopsMustUseBracesRule">
+    <description>
+    Avoid using 'while' statements without using curly braces
+    </description>
+
+    <example>
+<![CDATA[
+  public void doSomething() {
+    while (true)
+        x++;
+  }
+]]>
+    </example>
+  </rule>
+
+  <rule name="ForLoopsMustUseBracesRule"
+        message="Avoid using 'for' statements without curly braces"
+        class="net.sourceforge.pmd.rules.ForLoopsMustUseBracesRule">
+    <description>
+    Avoid using 'for' statements without using curly braces
+    </description>
+
+    <example>
+<![CDATA[
+  public void foo() {
+    for (int i=0; i<42;i++)
+        foo();
+  }
+]]>
+    </example>
+  </rule>
+
+  </ruleset>
+
+
+
diff --git a/pmd/rulesets/rulesets.properties b/pmd/rulesets/rulesets.properties
index 03f791eab7..ddcad49cdd 100644
--- a/pmd/rulesets/rulesets.properties
+++ b/pmd/rulesets/rulesets.properties
@@ -1 +1 @@
-rulesets.filenames=rulesets/basic.xml,rulesets/unusedcode.xml,rulesets/design.xml,rulesets/naming.xml,rulesets/imports.xml
\ No newline at end of file
+rulesets.filenames=rulesets/braces.xml,rulesets/basic.xml,rulesets/unusedcode.xml,rulesets/design.xml,rulesets/naming.xml,rulesets/imports.xml
\ No newline at end of file