From be028ccaefca40dbf2ab53db023f2df72ffbbcb6 Mon Sep 17 00:00:00 2001
From: Romain Pelisse <rpelisse@users.sourceforge.net>
Date: Tue, 24 Jun 2008 12:03:34 +0000
Subject: [PATCH] Adding a proper example to TooFewBranchesForASwitchStatement

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6266 51baf565-9d33-0410-a72c-fc3788e3496d
---
 pmd/rulesets/design.xml | 76 +++++++++++++++++++++++------------------
 1 file changed, 43 insertions(+), 33 deletions(-)

diff --git a/pmd/rulesets/design.xml b/pmd/rulesets/design.xml
index 8ba3694122..91bface827 100644
--- a/pmd/rulesets/design.xml
+++ b/pmd/rulesets/design.xml
@@ -1591,40 +1591,50 @@ public class abstract Example {
         </example>
     </rule>
 
-        <rule	name="TooFewBranchesForASwitchStatement"
-            since="4.2"
-	        	class="net.sourceforge.pmd.rules.XPathRule"
-	        	message="A switch with less than 3 branches is inefficient, use a if statement instead."
-	        	externalInfoUrl="http://pmd.sourceforge.net/rules/design.html#TooFewBranchesForASwitchStatement">
-        <description>
-            <![CDATA[
-				Swith are designed complex branches, and allow branches to share treatement. Using a switch for only 2
-				branches is ill advised, as switches are not as easy to understand as if. In this case, it's most likely
-				is a good idea to use a if statement instead, at least to increase code readability.
-            ]]>
-        </description>
-        <priority>1</priority>
-        <properties>
-        	<property name="minimumNumberCaseForASwitch" description="Minimum number of branches for a switch" value="3"/>
-            <property name="xpath">
-                <value>
-                    <![CDATA[
-//SwitchStatement[
-	(count(.//SwitchLabel) < $minimumNumberCaseForASwitch)
-]
-                    ]]>
-                </value>
-            </property>
-        </properties>
-        <example>
-            <![CDATA[
-public class abstract Example {
-	String field;
-	int otherField;
+	<rule	name="TooFewBranchesForASwitchStatement"
+		language="java"
+		since="4.2"
+		class="net.sourceforge.pmd.lang.rule.XPathRule"
+		message="A switch with less than 3 branches is inefficient, use a if statement instead."
+		externalInfoUrl="http://pmd.sourceforge.net/rules/design.html#TooFewBranchesForASwitchStatement">
+	    <description>
+		    <![CDATA[
+			     Swith are designed complex branches, and allow branches to share treatement. Using a switch for only a few 
+			     branches is ill advised, as switches are not as easy to understand as if. In this case, it's most likely
+			     is a good idea to use a if statement instead, at least to increase code readability.
+			     ]]>
+	    </description>
+	    <priority>1</priority>
+	    <properties>
+		    <property name="minimumNumberCaseForASwitch" description="Minimum number of branches for a switch" value="3"/>
+		    <property name="xpath">
+			    <value>
+				    <![CDATA[
+					     //SwitchStatement[
+					     (count(.//SwitchLabel) < $minimumNumberCaseForASwitch)
+								      ]
+								      ]]>
+					     </value>
+				     </property>
+			     </properties>
+			     <example>
+				     <![CDATA[
+// With a minimumNumberCaseForASwitch of 3	    
+public class Foo {
+	public void bar() {
+		switch (condition) {
+			case ONE:
+				instruction;
+				break;
+			default:
+				break; // not enough for a 'switch' stmt, a simple 'if' stmt would have been more appropriate
+		}
+	}
 }
-            ]]>
-        </example>
-    </rule>
+					      ]]>
+			     </example>
+	</rule>
+
 <!--
 	<rule 	name="TooManyHttpFilter"
 	         since="4.2"