From bf2460c16d7de816d5e40d2ea1dab571bd7d6b19 Mon Sep 17 00:00:00 2001 From: Jerome Russ Date: Tue, 8 Nov 2016 16:27:27 -0600 Subject: [PATCH] Changing methods to lowercase so casing doesn't matter Apex is case-insensitive so removing casing from the check for asserts. --- .../rule/apexunit/ApexUnitTestClassShouldHaveAsserts.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/apexunit/ApexUnitTestClassShouldHaveAsserts.java b/pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/apexunit/ApexUnitTestClassShouldHaveAsserts.java index 5d5613bb4e..2671d1602d 100644 --- a/pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/apexunit/ApexUnitTestClassShouldHaveAsserts.java +++ b/pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/apexunit/ApexUnitTestClassShouldHaveAsserts.java @@ -23,9 +23,9 @@ public class ApexUnitTestClassShouldHaveAsserts extends AbstractApexUnitTestRule private static final Set ASSERT_METHODS = new HashSet<>(); static { - ASSERT_METHODS.add("System.assert"); - ASSERT_METHODS.add("System.assertEquals"); - ASSERT_METHODS.add("System.assertNotEquals"); + ASSERT_METHODS.add("system.assert"); + ASSERT_METHODS.add("system.assertequals"); + ASSERT_METHODS.add("system.assertnotequals"); } @Override @@ -48,7 +48,7 @@ public class ApexUnitTestClassShouldHaveAsserts extends AbstractApexUnitTestRule boolean isAssertFound = false; for (final ASTMethodCallExpression methodCallExpression : methodCalls) { - if (ASSERT_METHODS.contains(methodCallExpression.getFullMethodName())) { + if (ASSERT_METHODS.contains(methodCallExpression.getFullMethodName().toLowerCase())) { isAssertFound = true; break; }