diff --git a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/bestpractices/AvoidUsingHardCodedIPRule.java b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/bestpractices/AvoidUsingHardCodedIPRule.java index 55336967f0..abda97d238 100644 --- a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/bestpractices/AvoidUsingHardCodedIPRule.java +++ b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/bestpractices/AvoidUsingHardCodedIPRule.java @@ -108,7 +108,7 @@ public class AvoidUsingHardCodedIPRule extends AbstractJavaRule { } protected boolean isHexCharacter(char c) { - return isLatinDigit(c) || 'A' <= c && c <= 'F' || 'a' <= c && c <= 'f'; + return isLatinDigit(c) || ('A' <= c && c <= 'F') || ('a' <= c && c <= 'f'); } protected boolean isIPv4(final char firstChar, final String s) { @@ -190,7 +190,7 @@ public class AvoidUsingHardCodedIPRule extends AbstractJavaRule { } } catch (NumberFormatException e) { // The last part can be a standard IPv4 address. - if (i != parts.length - 1 || !isIPv4(firstChar, part)) { + if (i != parts.length - 1 || !isIPv4(part.charAt(0), part)) { return false; } ipv4Mapped = true;