From cdf3d2a9cb669ebc29a021b4581672328bb0b763 Mon Sep 17 00:00:00 2001 From: Andreas Dangel Date: Tue, 30 Jul 2013 21:00:52 +0200 Subject: [PATCH] pmd: update changelog etc. with new rule ConsecutiveAppendsShouldReuse --- pmd/etc/changelog.txt | 2 ++ pmd/src/main/resources/rulesets/java/strings.xml | 2 +- pmd/src/main/resources/rulesets/releases/510.xml | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/pmd/etc/changelog.txt b/pmd/etc/changelog.txt index 767eb37a03..3ed809f408 100644 --- a/pmd/etc/changelog.txt +++ b/pmd/etc/changelog.txt @@ -15,6 +15,8 @@ New Java rules: - basic rule to check for existence for formal (javadoc) comments. AvoidProtectedMethodInFinalClassNotExtending - rule to avoid protected methods in final classes that don't extend anything other than Object. + ConsecutiveAppendsShouldReuse + - rule to encourage to reuse StringBuilder.append returned object for consecutive calls. CPD Command Line Changes: Added non-recursive option "--non-recursive" to not scan sub-directories diff --git a/pmd/src/main/resources/rulesets/java/strings.xml b/pmd/src/main/resources/rulesets/java/strings.xml index c5cbaba164..06008f5ebe 100644 --- a/pmd/src/main/resources/rulesets/java/strings.xml +++ b/pmd/src/main/resources/rulesets/java/strings.xml @@ -154,7 +154,7 @@ sb.append('a'); // use this instead class="net.sourceforge.pmd.lang.rule.XPathRule" externalInfoUrl="${pmd.website.baseurl}/rules/java/strings.html#ConsecutiveAppendsShouldReuse"> -Consecutively calls to StringBuffer/StringBuilder .append must reuse the target object. This will improve the performance. +Consecutively calls to StringBuffer/StringBuilder .append should reuse the target object. This can improve the performance. 3 diff --git a/pmd/src/main/resources/rulesets/releases/510.xml b/pmd/src/main/resources/rulesets/releases/510.xml index 7a10be3bb3..e08decf54c 100644 --- a/pmd/src/main/resources/rulesets/releases/510.xml +++ b/pmd/src/main/resources/rulesets/releases/510.xml @@ -14,5 +14,6 @@ This ruleset contains links to rules that are new in PMD v5.1.0 +