From 312863820c8bb1c470d5531154f7200d6c61c90b Mon Sep 17 00:00:00 2001
From: Andreas Dangel <andreas.dangel@pmd-code.org>
Date: Mon, 3 Aug 2020 18:25:00 +0000
Subject: [PATCH] [java] Improve example for AvoidSynchronizedAtMethodLevel

---
 .../category/java/multithreading.xml          | 54 +++++++++++++------
 1 file changed, 37 insertions(+), 17 deletions(-)

diff --git a/pmd-java/src/main/resources/category/java/multithreading.xml b/pmd-java/src/main/resources/category/java/multithreading.xml
index 097bd6e053..c01e70971a 100644
--- a/pmd-java/src/main/resources/category/java/multithreading.xml
+++ b/pmd-java/src/main/resources/category/java/multithreading.xml
@@ -24,30 +24,50 @@ gets it.
         <properties>
             <property name="version" value="2.0"/>
             <property name="xpath">
-                <value>//MethodDeclaration[@Synchronized= true()]</value>
+                <value>//MethodDeclaration[@Synchronized = true()]</value>
             </property>
         </properties>
         <example>
 <![CDATA[
 public class Foo {
-  // Try to avoid this:
-  synchronized void foo() {
-  }
-  // Prefer this:
-  void bar() {
-    synchronized(this) {
+    // Try to avoid this:
+    synchronized void foo() {
+        // code, that doesn't need synchronization
+        // ...
+        // code, that requires synchronization
+        if (!sharedData.has("bar")) {
+            sharedData.add("bar");
+        }
+        // more code, that doesn't need synchronization
+        // ...
     }
-  }
-
-  // Try to avoid this for static methods:
-  static synchronized void fooStatic() {
-  }
-
-  // Prefer this:
-  static void barStatic() {
-    synchronized(Foo.class) {
+    // Prefer this:
+    void bar() {
+        // code, that doesn't need synchronization
+        // ...
+        synchronized(this) {
+            if (!sharedData.has("bar")) {
+                sharedData.add("bar");
+            }
+        }
+        // more code, that doesn't need synchronization
+        // ...
+    }
+
+    // Try to avoid this for static methods:
+    static synchronized void fooStatic() {
+    }
+
+    // Prefer this:
+    static void barStatic() {
+        // code, that doesn't need synchronization
+        // ...
+        synchronized(Foo.class) {
+            // code, that requires synchronization
+        }
+        // more code, that doesn't need synchronization
+        // ...
     }
-  }
 }
 ]]>
         </example>