From d1eb55741feb8c1afc122ebc22c87196d20a4eca Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juan=20Mart=C3=ADn=20Sotuyo=20Dodero?=
 <juan.sotuyo@pedidosya.com>
Date: Mon, 25 Mar 2024 00:44:12 -0300
Subject: [PATCH] Add test case for #3436

---
 .../java/rule/errorprone/xml/ProperLogger.xml | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/errorprone/xml/ProperLogger.xml b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/errorprone/xml/ProperLogger.xml
index 32b15f8d29..c2c71f3d81 100644
--- a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/errorprone/xml/ProperLogger.xml
+++ b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/errorprone/xml/ProperLogger.xml
@@ -309,6 +309,33 @@ public class ProperLoggerSample {
     public PropperLoggerSample() {
         log = LogFactory.getLog(ProperLoggerSample.class);
     }
+}
+        ]]></code>
+    </test-code>
+
+    <test-code>
+        <description>[java] ProperLogger gives false positives for inner classes #3436</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class ResultHolders {
+  private ResultHolders() {
+    super();
+  }
+
+  private static class SynchronizedHolder {
+    private static final Logger LOG = LoggerFactory.getLogger(SynchronizedHolder.class);
+  }
+
+  private static class JMSHolder {
+    private static final Logger LOG = LoggerFactory.getLogger(SynchronizedHolder.class);
+  }
+
+  static class ResultMessage {
+    private static final Logger LOG = LoggerFactory.getLogger(ResultMessage.class);
+  }
 }
         ]]></code>
     </test-code>