Priority: Medium (3)
-All switch statements should include a default option to catch any unspecified values.
+Switch statements should be exhaustive, to make their control flow
+easier to follow. This can be achieved by adding a default case, or,
+if the switch is on an enum type, by ensuring there is one switch branch
+for each enum constant.
This rule is defined by the following XPath expression:
//SwitchStatement[@DefaultCase = false() and @ExhaustiveEnumSwitch = false()]
@@ -2935,14 +2938,14 @@ effectively.
Example(s):
-public void bar() {
+class Foo {{
int x = 2;
switch (x) {
case 1: int j = 6;
case 2: int j = 8;
- // missing default: here
+ // missing default: here
}
-}
+}}
Use this rule by referencing it:
diff --git a/pmd_rules_java_errorprone.html b/pmd_rules_java_errorprone.html
index b649521d4d..756133e430 100644
--- a/pmd_rules_java_errorprone.html
+++ b/pmd_rules_java_errorprone.html
@@ -4633,9 +4633,9 @@ for each call and new objects will be created for every invocation.
Priority: Medium High (2)
-Some classes contain overloaded getInstance. The problem with overloaded getInstance methods
-is that the instance created using the overloaded method is not cached and so,
-for each call and new objects will be created for every invocation.
+A singleton class should only ever have one instance. Failure to check
+whether an instance has already been created may result in multiple
+instances being created.
This rule is defined by the following Java class: net.sourceforge.pmd.lang.java.rule.errorprone.SingletonClassReturningNewInstanceRule
@@ -4645,7 +4645,7 @@ for each call and new objects will be created for every invocation.
private static Singleton instance = null;
public static Singleton getInstance() {
synchronized(Singleton.class) {
- return new Singleton();
+ return new Singleton(); // this should be assigned to the field
}
}
}