diff --git a/pmd-vm/src/main/java/net/sourceforge/pmd/lang/vm/rule/design/NoInlineJavaScriptRule.java b/pmd-vm/src/main/java/net/sourceforge/pmd/lang/vm/rule/design/NoInlineJavaScriptRule.java index b52831e8c4..37b84db61b 100644 --- a/pmd-vm/src/main/java/net/sourceforge/pmd/lang/vm/rule/design/NoInlineJavaScriptRule.java +++ b/pmd-vm/src/main/java/net/sourceforge/pmd/lang/vm/rule/design/NoInlineJavaScriptRule.java @@ -11,14 +11,15 @@ import net.sourceforge.pmd.lang.vm.ast.ASTText; import net.sourceforge.pmd.lang.vm.rule.AbstractVmRule; public class NoInlineJavaScriptRule extends AbstractVmRule { + private static final Pattern SCRIPT_PATTERN = Pattern.compile("]*>", Pattern.CASE_INSENSITIVE); + private static final Pattern SRC_PATTERN = Pattern.compile("\\ssrc\\s*=", Pattern.CASE_INSENSITIVE); + @Override public Object visit(final ASTText node, final Object data) { - final Pattern scriptPattern = Pattern.compile("]*>", Pattern.CASE_INSENSITIVE); - final Pattern srcPattern = Pattern.compile("\\ssrc\\s*=", Pattern.CASE_INSENSITIVE); - final Matcher matcher = scriptPattern.matcher(node.literal()); + final Matcher matcher = SCRIPT_PATTERN.matcher(node.literal()); while (matcher.find()) { final String currentMatch = matcher.group(); - if (!srcPattern.matcher(currentMatch).find()) { + if (!SRC_PATTERN.matcher(currentMatch).find()) { addViolation(data, node); } }