From e2fe6d1621377341a0049091da797a13fd482b63 Mon Sep 17 00:00:00 2001
From: Brian Remedios <hooperbloob@users.sourceforge.net>
Date: Mon, 5 Dec 2011 10:18:10 +0000
Subject: [PATCH] minor tweaks

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@7515 51baf565-9d33-0410-a72c-fc3788e3496d
---
 .../pmd/eclipse/ui/actions/GenerateReportAction.java  | 11 ++++++++++-
 .../pmd/eclipse/ui/reports/ReportPreferencesPage.java |  5 -----
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/pmd-eclipse-plugin/plugins/net.sourceforge.pmd.eclipse.plugin/src/net/sourceforge/pmd/eclipse/ui/actions/GenerateReportAction.java b/pmd-eclipse-plugin/plugins/net.sourceforge.pmd.eclipse.plugin/src/net/sourceforge/pmd/eclipse/ui/actions/GenerateReportAction.java
index 68e3decce8..0e545637a7 100644
--- a/pmd-eclipse-plugin/plugins/net.sourceforge.pmd.eclipse.plugin/src/net/sourceforge/pmd/eclipse/ui/actions/GenerateReportAction.java
+++ b/pmd-eclipse-plugin/plugins/net.sourceforge.pmd.eclipse.plugin/src/net/sourceforge/pmd/eclipse/ui/actions/GenerateReportAction.java
@@ -1,5 +1,7 @@
 package net.sourceforge.pmd.eclipse.ui.actions;
 
+import java.util.List;
+
 import name.herlin.command.CommandException;
 import net.sourceforge.pmd.eclipse.plugin.PMDPlugin;
 import net.sourceforge.pmd.eclipse.runtime.cmd.RenderReportsCmd;
@@ -39,10 +41,17 @@ public class GenerateReportAction extends AbstractUIAction {
     }
     
     private boolean checkRenderers() {
+    	    	
+    	List<Renderer> renderers = ReportManager.instance.activeRenderers();
     	
+    	if (renderers.isEmpty()) {
+    		PMDPlugin.getDefault().showUserError("No report renderers selected");
+    		return false;
+    	}    	
+
     	StringBuilder errors = new StringBuilder();
     	
-    	for (Renderer renderer : ReportManager.instance.activeRenderers()) {
+    	for (Renderer renderer : renderers) {
      	   String issue = renderer.dysfunctionReason();
      	   if (StringUtil.isNotEmpty(issue)) {
      		  errors.append(renderer.getName()).append(": ");
diff --git a/pmd-eclipse-plugin/plugins/net.sourceforge.pmd.eclipse.plugin/src/net/sourceforge/pmd/eclipse/ui/reports/ReportPreferencesPage.java b/pmd-eclipse-plugin/plugins/net.sourceforge.pmd.eclipse.plugin/src/net/sourceforge/pmd/eclipse/ui/reports/ReportPreferencesPage.java
index 0fb849184d..e9fffc4b3b 100644
--- a/pmd-eclipse-plugin/plugins/net.sourceforge.pmd.eclipse.plugin/src/net/sourceforge/pmd/eclipse/ui/reports/ReportPreferencesPage.java
+++ b/pmd-eclipse-plugin/plugins/net.sourceforge.pmd.eclipse.plugin/src/net/sourceforge/pmd/eclipse/ui/reports/ReportPreferencesPage.java
@@ -1,11 +1,7 @@
 package net.sourceforge.pmd.eclipse.ui.reports;
 
-import java.io.FileInputStream;
-import java.io.FileOutputStream;
 import java.util.HashSet;
 import java.util.List;
-import java.util.Map;
-import java.util.Properties;
 import java.util.Set;
 
 import net.sourceforge.pmd.PropertyDescriptor;
@@ -20,7 +16,6 @@ import net.sourceforge.pmd.eclipse.ui.preferences.br.ValueChangeListener;
 import net.sourceforge.pmd.eclipse.ui.preferences.panelmanagers.FormArranger;
 import net.sourceforge.pmd.eclipse.ui.preferences.panelmanagers.PerRulePropertyPanelManager;
 import net.sourceforge.pmd.renderers.Renderer;
-import net.sourceforge.pmd.util.IOUtil;
 import net.sourceforge.pmd.util.StringUtil;
 
 import org.eclipse.jface.preference.PreferencePage;