From e9abdf7a9218a117a886f499d88becd0e9c8b876 Mon Sep 17 00:00:00 2001
From: Andreas Dangel <andreas.dangel@adangel.org>
Date: Sun, 11 Feb 2018 10:57:36 +0100
Subject: [PATCH] Update pmd configuration to use dogfood and fail build on
 violations Refs #361

---
 pom.xml | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index df9f3674a3..2af52c7029 100644
--- a/pom.xml
+++ b/pom.xml
@@ -515,7 +515,7 @@ Additionally it includes CPD, the copy-paste-detector. CPD finds duplicated code
                     <execution>
                         <phase>verify</phase>
                         <goals>
-                            <goal>pmd</goal>
+                            <goal>check</goal>
                             <goal>cpd</goal>
                         </goals>
                     </execution>
@@ -524,12 +524,14 @@ Additionally it includes CPD, the copy-paste-detector. CPD finds duplicated code
                     <minimumTokens>100</minimumTokens>
                     <targetJdk>1.${java.version}</targetJdk>
                     <rulesets>
-                        <ruleset>${pmd.dogfood.ruleset}</ruleset>
+                        <ruleset>/net/sourceforge/pmd/pmd-dogfood-config.xml</ruleset>
                     </rulesets>
                     <excludeRoots>
                         <excludeRoot>target/generated-sources/javacc</excludeRoot>
                     </excludeRoots>
                     <skipPmdError>false</skipPmdError>
+                    <failOnViolation>true</failOnViolation>
+                    <printFailingErrors>true</printFailingErrors>
                 </configuration>
                 <dependencies>
                     <!-- Note: we can't use a property for the version here due to https://issues.apache.org/jira/browse/MRELEASE-932 -->
@@ -543,6 +545,12 @@ Additionally it includes CPD, the copy-paste-detector. CPD finds duplicated code
                         <artifactId>pmd-java</artifactId>
                         <version>6.0.1</version>
                     </dependency>
+                    <!-- This contains the dogfood ruleset -->
+                    <dependency>
+                        <groupId>net.sourceforge.pmd</groupId>
+                        <artifactId>pmd-build-tools-config</artifactId>
+                        <version>1.1.0-SNAPSHOT</version>
+                    </dependency>
                 </dependencies>
             </plugin>
             <plugin>