diff --git a/pmd-java/src/main/resources/rulesets/java/unnecessary.xml b/pmd-java/src/main/resources/rulesets/java/unnecessary.xml index a488c88eac..d6efe8fe2b 100644 --- a/pmd-java/src/main/resources/rulesets/java/unnecessary.xml +++ b/pmd-java/src/main/resources/rulesets/java/unnecessary.xml @@ -70,7 +70,9 @@ tagged as such. diff --git a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/unnecessary/xml/UnnecessaryFinalModifier.xml b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/unnecessary/xml/UnnecessaryFinalModifier.xml index 614de0cf19..f6e996faae 100644 --- a/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/unnecessary/xml/UnnecessaryFinalModifier.xml +++ b/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/unnecessary/xml/UnnecessaryFinalModifier.xml @@ -97,4 +97,23 @@ public final class Foo { } ]]> + + + #1464 UnnecessaryFinalModifier false positive on a @SafeVarargs method + 0 + { + @SafeVarargs + public final InboxContents conflateWith(T... values) { // false positive + return conflateWith(ImmutableList.copyOf(values)); + } +} +public final class InboxContents2 { + @java.lang.SafeVarargs + public final InboxContents conflateWith(String... values) { + return conflateWith(ImmutableList.copyOf(values)); + } +} + ]]> + diff --git a/src/site/markdown/overview/changelog.md b/src/site/markdown/overview/changelog.md index c268023ab4..ee6918c18c 100644 --- a/src/site/markdown/overview/changelog.md +++ b/src/site/markdown/overview/changelog.md @@ -78,6 +78,8 @@ * [#1443](https://sourceforge.net/p/pmd/bugs/1443/): RedundantFieldInitializer: False positive for small floats * java-optimizations/UseStringBufferForStringAppends: * [#1340](https://sourceforge.net/p/pmd/bugs/1340/): UseStringBufferForStringAppends False Positive with ternary operator +* java-unnecessary/UnnecessaryFinalModifier: + * [#1464](https://sourceforge.net/p/pmd/bugs/1464/): UnnecessaryFinalModifier false positive on a @SafeVarargs method * java-unnecessary/UselessQualifiedThis * [#1422](https://sourceforge.net/p/pmd/bugs/1422/): UselessQualifiedThis: False positive with Java 8 Function * java-unusedcode/UnusedFormalParameter: