From 8c7a5d06645cbbd19c2625ebbff6f899d6babb1d Mon Sep 17 00:00:00 2001 From: Andreas Dangel Date: Fri, 19 Jul 2024 10:16:33 +0200 Subject: [PATCH] [cli] Fix pmd.bat for Windows when starting designer with JAVAFX_HOME Fixes #5120 --- docs/pages/release_notes.md | 2 ++ pmd-dist/src/main/resources/scripts/pmd.bat | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/pages/release_notes.md b/docs/pages/release_notes.md index e9e45b1d5f..7241a17c40 100644 --- a/docs/pages/release_notes.md +++ b/docs/pages/release_notes.md @@ -38,6 +38,8 @@ This is a {{ site.pmd.release_type }} release. * [#5086](https://github.com/pmd/pmd/pull/5086): \[plsql] Fixed issue with missing optional table alias in MERGE usage * [#5087](https://github.com/pmd/pmd/pull/5087): \[plsql] Add support for SQL_MACRO * [#5088](https://github.com/pmd/pmd/pull/5088): \[plsql] Add support for 'DEFAULT' clause on the arguments of some oracle functions +* cli + * [#5120](https://github.com/pmd/pmd/issues/5120): \[cli] Can't start designer under Windows ### 🚨 API Changes diff --git a/pmd-dist/src/main/resources/scripts/pmd.bat b/pmd-dist/src/main/resources/scripts/pmd.bat index 1e0d4b6e4a..482d0d8c7e 100644 --- a/pmd-dist/src/main/resources/scripts/pmd.bat +++ b/pmd-dist/src/main/resources/scripts/pmd.bat @@ -67,8 +67,10 @@ if %_needjfxlib% EQU 1 ( ) rem The wildcard will include only jar files, but we need to access also rem property files such as javafx.properties that lay bare in the dir - set pmd_classpath=%TOPDIR%\conf;%TOPDIR%\lib\*;%JAVAFX_HOME%\lib\*;%JAVAFX_HOME%\lib\ + rem note: no trailing backslash, as this would escape a following quote when %pmd_classpath% is used later + set pmd_classpath=%TOPDIR%\conf;%TOPDIR%\lib\*;%JAVAFX_HOME%\lib\*;%JAVAFX_HOME%\lib ) else ( + rem note: no trailing backslash, as this would escape a following quote when %pmd_classpath% is used later set pmd_classpath=%TOPDIR%\conf;%TOPDIR%\lib\* )