diff --git a/pmd/bin/build.xml b/pmd/bin/build.xml index 8170f08cb9..b370b2688c 100644 --- a/pmd/bin/build.xml +++ b/pmd/bin/build.xml @@ -1,4 +1,4 @@ - + @@ -72,10 +72,10 @@ - - - - + + + + diff --git a/pmd/etc/changelog.txt b/pmd/etc/changelog.txt index 6133fe2c4e..411f01286e 100644 --- a/pmd/etc/changelog.txt +++ b/pmd/etc/changelog.txt @@ -5,6 +5,7 @@ Fixed bug 1227001 - AvoidCallingFinalize no longer flags calls to finalize() wit Fixed a bug in RuleSetFactory that missed some override cases; thx to Wouter Zelle for the report and a fix. Improved UseCorrectExceptionLogging; thx to Wouter Zelle for the new XPath. The Ant task now accepts the short names of rulesets (e.g., unusedcode for rulesets/unusedcode.xml). +Removed unnecessary '.html' suffix to HTML renderer when the linkPrefix attribute is used. Moved AvoidCallingFinalize from the design ruleset to the finalize ruleset. Deleted redundant ExplicitCallToFinalize rule. diff --git a/pmd/src/net/sourceforge/pmd/renderers/HTMLRenderer.java b/pmd/src/net/sourceforge/pmd/renderers/HTMLRenderer.java index 6ecf487e74..7a6731fd8c 100644 --- a/pmd/src/net/sourceforge/pmd/renderers/HTMLRenderer.java +++ b/pmd/src/net/sourceforge/pmd/renderers/HTMLRenderer.java @@ -68,7 +68,7 @@ public class HTMLRenderer implements Renderer { if (linkPrefix == null) { return filename; } - String newFileName = filename.substring(0, filename.indexOf(".java")) + ".html"; - return "" + newFileName + ""; + String newFileName = filename.substring(0, filename.indexOf(".java")); + return "" + newFileName + ""; } } diff --git a/pmd/xdocs/ant-task.xml b/pmd/xdocs/ant-task.xml index 1137819ebf..51120122b1 100644 --- a/pmd/xdocs/ant-task.xml +++ b/pmd/xdocs/ant-task.xml @@ -87,7 +87,7 @@ - + @@ -104,7 +104,7 @@ - + @@ -194,7 +194,7 @@ Total time: 2 seconds - + @@ -204,7 +204,6 @@ Total time: 2 seconds ]]> -

Using the ruleset nested element

rulesets/favorites.xml - rulesets/basic.xml - + basic