From f8ca4a75d3052babd3413b3cab18b64bef2c1e86 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Fournier?= Date: Sat, 20 Jan 2018 01:53:23 +0100 Subject: [PATCH] Extract Pattern constant from parse method --- .../net/sourceforge/pmd/lang/java/ast/JavaQualifiedName.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/JavaQualifiedName.java b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/JavaQualifiedName.java index 9896663f32..30fa254b9c 100644 --- a/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/JavaQualifiedName.java +++ b/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/JavaQualifiedName.java @@ -76,6 +76,7 @@ public final class JavaQualifiedName implements QualifiedName { // maps class names to the names of their local classes, to the count of local classes with the same name private static final Map> LOCAL_INDICES = new WeakHashMap<>(); + private static final Pattern LOCAL_INDEX_PATTERN = Pattern.compile("(\\d+)(\\w+)"); private String[] packages = null; // unnamed package private String[] classes = new String[1]; @@ -292,10 +293,9 @@ public final class JavaQualifiedName implements QualifiedName { qname.classes = matcher.group(CLASSES_GROUP_INDEX).split("\\$"); qname.localIndices = new int[qname.classes.length]; - Pattern localIndexPattern = Pattern.compile("(\\d+)(\\w+)"); for (int i = 0; i < qname.classes.length; i++) { - Matcher localIndexMatcher = localIndexPattern.matcher(qname.classes[i]); + Matcher localIndexMatcher = LOCAL_INDEX_PATTERN.matcher(qname.classes[i]); if (localIndexMatcher.matches()) { qname.localIndices[i] = Integer.parseInt(localIndexMatcher.group(1)); qname.classes[i] = localIndexMatcher.group(2);