From b8d822eb354a593584aa382d716cec8dd197aeb8 Mon Sep 17 00:00:00 2001 From: Brecht Van Lommel Date: Sun, 2 Dec 2012 08:25:40 +0000 Subject: [PATCH] Fix performance issue in OSL geometry node, compiler fails to optimize out the tangent computation, tweaked the code so this works. --- intern/cycles/kernel/shaders/node_geometry.osl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/intern/cycles/kernel/shaders/node_geometry.osl b/intern/cycles/kernel/shaders/node_geometry.osl index 3940b98eec1..5a784f951bb 100644 --- a/intern/cycles/kernel/shaders/node_geometry.osl +++ b/intern/cycles/kernel/shaders/node_geometry.osl @@ -51,7 +51,12 @@ shader node_geometry( /* try to create spherical tangent from generated coordinates */ if (getattribute("geom:generated", generated)) { - vector T = vector(-(generated[1] - 0.5), (generated[0] - 0.5), 0.0); + matrix project = matrix(0.0, 1.0, 0.0, 0.0, + -1.0, 0.0, 0.0, 0.0, + 0.0, 0.0, 0.0, 0.0, + 0.5, -0.5, 0.0, 1.0); + + vector T = transform(project, generated); T = transform("object", "world", T); Tangent = cross(Normal, normalize(cross(T, Normal))); }