From cb4391996744e1479b4cdc7479a5a1b143630611 Mon Sep 17 00:00:00 2001 From: Mikkel Oscar Lyderik Larsen Date: Thu, 7 Dec 2023 16:50:40 +0100 Subject: [PATCH 1/2] Fix table for nakadi docs Signed-off-by: Mikkel Oscar Lyderik Larsen --- README.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/README.md b/README.md index 4533164..d116896 100644 --- a/README.md +++ b/README.md @@ -714,9 +714,6 @@ The Nakadi collector allows scaling based on [Nakadi](https://nakadi.io/) |------------------------|-----------------------------------------------------------------------------|----------|--------------| | `unconsumed-events` | Scale based on number of unconsumed events for a Nakadi subscription | External | `>=1.24` | | `consumer-lag-seconds` | Scale based on number of max consumer lag seconds for a Nakadi subscription | External | `>=1.24` | -| ------------ | ------- | -- | -- | -| `unconsumed-events` | Scale based on number of unconsumed events for a Nakadi Subscription | External | `>=1.24` | -| `consumer-lag-seconds` | Scale based on number of max consumer lag seconds for a Nakadi Subscription | External | `>=1.24` | ```yaml apiVersion: autoscaling/v2 From 8190553285a2df6e77543daa899044a34512c66f Mon Sep 17 00:00:00 2001 From: Mikkel Oscar Lyderik Larsen Date: Fri, 8 Dec 2023 17:02:21 +0100 Subject: [PATCH 2/2] Fix type for value target Signed-off-by: Mikkel Oscar Lyderik Larsen --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index d116896..599bb40 100644 --- a/README.md +++ b/README.md @@ -747,6 +747,7 @@ spec: # if an event-type has multiple partitions the value of # consumer-lag-seconds is the max of all the partitions. value: "600" # 10m + type: Value # averageValue is compatible with unconsumed-events metric type. # This means for every 30 unconsumed events a pod is added. # unconsumed-events is the sum of of unconsumed_events over all