Shuenhoy/vtk-m
1
0
Fork 0
mirror of https://gitlab.kitware.com/vtk/vtk-m synced 2024-09-08 13:23:51 +00:00
Code Issues 2 Actions Packages Projects Releases Wiki Activity

Refactor IsWritableArrayHandle to use PortalSupportsSets.

Browse Source
This commit is contained in:
Allison Vacanti 2019-09-05 18:42:05 -04:00
parent dc98517b98
commit 29ea46fa52
2 changed files with 32 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
vtkm/cont/ArrayHandle.h
View File

@ -77,34 +77,35 @@ struct IsInValidArrayHandle
namespace detail
{
template <typename ArrayHandle>
struct IsWritableArrayHandleImpl
template <typename PortalType>
struct IsWritableArrayPortalImpl
{
private:
template <typename U,
typename S = decltype(std::declval<U>().Set(vtkm::Id{},
std::declval<typename U::ValueType>()))>
typename VT = typename U::ValueType,
typename S = decltype(std::declval<U>().Set(0, std::declval<VT>()))>
static std::true_type hasSet(int);
template <typename U>
static std::false_type hasSet(...);
using PortalType = typename ArrayHandle::PortalControl;
public:
using type = decltype(hasSet<PortalType>(0));
static constexpr bool value = type::value;
};
}
/// Checks to see if the ArrayHandle allows
/// writing, as some ArrayHandles (Implicit) don't support writing.
/// This check is compatible with the C++11 type_traits.
/// It contains a typedef named type that is either
/// std::true_type or std::false_type.
/// Both of these have a typedef named value with the respective boolean value.
///
} // namespace detail
/// Checks to see if the ArrayHandle or ArrayPortal allows writing, as some
/// ArrayHandles (Implicit) don't support writing. These will be defined as
/// either std::true_type or std::false_type.
/// @{
template <typename PortalType>
using IsWritableArrayPortal = typename detail::IsWritableArrayPortalImpl<PortalType>::type;
template <typename ArrayHandle>
using IsWritableArrayHandle = typename detail::IsWritableArrayHandleImpl<ArrayHandle>::type;
using IsWritableArrayHandle =
IsWritableArrayPortal<typename std::decay<ArrayHandle>::type::PortalControl>;
/// @}
/// Checks to see if the given object is an array handle. This check is
/// compatible with C++11 type_traits. It a typedef named \c type that is

17
vtkm/internal/ArrayPortalHelpers.h
View File

@ -19,8 +19,11 @@ namespace vtkm
namespace internal
{
namespace detail
{
template <typename PortalType>
struct PortalSupportsGets
struct PortalSupportsGetsImpl
{
template <typename U, typename S = decltype(std::declval<U>().Get(vtkm::Id{}))>
static std::true_type has(int);
@ -30,7 +33,7 @@ struct PortalSupportsGets
};
template <typename PortalType>
struct PortalSupportsSets
struct PortalSupportsSetsImpl
{
template <typename U,
typename S = decltype(std::declval<U>().Set(vtkm::Id{},
@ -40,6 +43,16 @@ struct PortalSupportsSets
static std::false_type has(...);
using type = decltype(has<PortalType>(0));
};
} // namespace detail
template <typename PortalType>
using PortalSupportsGets =
typename detail::PortalSupportsGetsImpl<typename std::decay<PortalType>::type>::type;
template <typename PortalType>
using PortalSupportsSets =
typename detail::PortalSupportsSetsImpl<typename std::decay<PortalType>::type>::type;
}
} // namespace vtkm::internal