Shuenhoy/vtk-m
1
0
Fork 0
mirror of https://gitlab.kitware.com/vtk/vtk-m synced 2024-09-08 13:23:51 +00:00
Code Issues 2 Actions Packages Projects Releases Wiki Activity

Merge topic 'external-face-miss-pair'

Browse Source 
194ddb5b4 Fix error in checking paired faces in ExternalFaces filter

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !3097
This commit is contained in:
Kenneth Moreland 2023-07-04 11:59:19 +00:00 committed by Kitware Robot
commit 7ccf62c797
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
docs/changelog/external-face-miss-pair.md Normal file
View File

@ -0,0 +1,8 @@
# Fixed error in checking paired faces in ExternalFaces filter
The `ExternalFaces` filter uses hash codes to find duplicate (i.e.
internal) faces. The issue with hash codes is that you have to deal with
unique entries that have identical hashes. The worklet to count how many
unique, unmatched faces were associated with each hash code was correct.
However, the code to then grab the ith unique face in a hash was wrong.
This has been fixed.

6
vtkm/filter/entity_extraction/worklet/ExternalFaces.h
View File

@ -452,8 +452,12 @@ private:
cellSet.GetIndices(originCells[myIndex]),
myFace);
bool foundPair = false;
for (vtkm::IdComponent otherIndex = myIndex + 1; otherIndex < numCellsOnHash; otherIndex++)
for (vtkm::IdComponent otherIndex = 0; otherIndex < numCellsOnHash; otherIndex++)
{
if (otherIndex == myIndex)
{
continue;
}
vtkm::Id3 otherFace;
vtkm::exec::CellFaceCanonicalId(originFaces[otherIndex],
cellSet.GetCellShape(originCells[otherIndex]),